GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-28334: netrc() now uses expanduser() to find .netrc file by berkerpeksag · Pull Request #4537 · python/cpython

Conversation

@berkerpeksag

@berkerpeksag berkerpeksag commented Nov 24, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Previously, netrc.netrc() was raised an exception if
$HOME is not set.

Authored-By: Dimitri Merejkowsky <[email protected]>

https://bugs.python.org/issue28334

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@dmerejkowsky @berkerpeksag
bpo-28334: fix netrc not working when $HOME is not set
ce9d8e6 
Also add more tests to check that proper exceptions are raised
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 24, 2017
@bedevere-bot bedevere-bot added the awaiting merge label Nov 24, 2017
@berkerpeksag berkerpeksag mentioned this pull request Nov 24, 2017
bpo-28334: fix netrc not working when $HOME is not set #123
Closed
@berkerpeksag berkerpeksag closed this Nov 24, 2017
@berkerpeksag berkerpeksag reopened this Nov 24, 2017
@berkerpeksag berkerpeksag changed the title [DO NOT MERGE] bpo-28334: fix netrc not working when $HOME is not set bpo-28334: fix netrc not working when $HOME is not set Nov 25, 2017
berkerpeksag added 2 commits November 25, 2017 13:16
@berkerpeksag
Update 2017-11-24-11-50-41.bpo-28334.3gGGlt.rst
54c08dc
@berkerpeksag
Update netrc.rst
afa6881
@berkerpeksag berkerpeksag changed the title bpo-28334: fix netrc not working when $HOME is not set bpo-28334: netrc.netrc() now uses os.path.expanduser() to find .netrc Nov 25, 2017
@berkerpeksag berkerpeksag changed the title bpo-28334: netrc.netrc() now uses os.path.expanduser() to find .netrc bpo-28334: netrc() now uses expanduser() to find .netrc file Nov 25, 2017
@berkerpeksag
berkerpeksag merged commit 8d9bb11 into python:master Nov 25, 2017
@bedevere-bot bedevere-bot removed the awaiting merge label Nov 25, 2017
@berkerpeksag
berkerpeksag deleted the 28334-netrc branch November 25, 2017 10:37
@sloria sloria mentioned this pull request Jan 12, 2018
Fail silently sloria/tinynetrc#2
Closed
sloria added a commit to sloria/tinynetrc that referenced this pull request Jan 12, 2018
@sloria
Use expanduser() to find netrc file
d923e8d 
Avoids an exception when $HOME is not set.
This behavior matches the behavior in Python 3.7
See python/cpython#4537

close #2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@berkerpeksag @the-knights-who-say-ni @bedevere-bot @dmerejkowsky
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.