GeezerVison is showing github.com — bpo-29779: new environment variable PYTHONHISTORY. · Pull Request #473 · python/cpython
bpo-29779: new environment variable PYTHONHISTORY.
#473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement . We’ll occasionally send you account related emails.
Already on GitHub?
Sign in
to your account
Uh oh!
There was an error while loading. Please reload this page.
Show file tree
Hide file tree
Changes from all commits
Commits
File filter
Filter by extension
.c
(1)
.man
(1)
.py
(2)
.rst
(1)
No extension
(1)
All 5 file types selected
Viewed files
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Hide whitespace
Diff view
Hide whitespace
There are no files selected for viewing
Original file line number
Diff line number
Diff line change
Expand Up
@@ -713,6 +713,13 @@ conflict.
.. versionadded:: 3.6
.. envvar:: PYTHONHISTORY
If set to a non-empty string, you can change the location of a python_history
Comment thread
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more .
"a ``.python_history`` file" or just "a history file".
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
file, by default it will be in ~/.python_history.
Comment thread
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more .
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
.. versionadded:: 3.7
Debug-mode variables
~~~~~~~~~~~~~~~~~~~~
Expand Down
Original file line number
Diff line number
Diff line change
Expand Up
@@ -372,6 +372,17 @@ def setcopyright():
def sethelper():
builtins.help = _sitebuiltins._Helper()
def gethistoryfile():
"""Check if PYTHONHISTORY environment variable
is set and define it as python_history file,
if not use the default ~/.python_history file.
"""
h = os.environ.get("PYTHONHISTORY")
if h != '':
Comment thread
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more .
What if os.environ.get("PYTHONHISTORY") returns None?
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
return h
return os.path.join(os.path.expanduser('~'),
'.python_history')
def enablerlcompleter():
"""Enable default readline configuration on interactive prompts, by
registering a sys.__interactivehook__.
Expand Down
Expand Up
@@ -407,13 +418,9 @@ def register_readline():
pass
if readline.get_current_history_length() == 0:
# If no history was loaded, default to .python_history.
# The guard is necessary to avoid doubling history size at
# each interpreter exit when readline was already configured
# through a PYTHONSTARTUP hook, see:
# http://bugs.python.org/issue5845#msg198636
history = os.path.join(os.path.expanduser('~'),
'.python_history')
# If no history was loaded, default to .python_history,
# or PYTHONHISTORY.
history = gethistoryfile()
try:
readline.read_history_file(history)
except IOError:
Expand Down
Original file line number
Diff line number
Diff line change
Expand Up
@@ -259,6 +259,10 @@ def test_getsitepackages(self):
wanted = os.path.join('xoxo', 'lib', 'site-packages')
self.assertEqual(dirs[1], wanted)
def test_gethistoryfile(self):
os.environ['PYTHONHISTORY'] = "xoxo"
Comment thread
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more .
Please use EnvironmentVarGuard in test.support to set env variables.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
self.assertEqual(site.gethistoryfile(), "xoxo")
class PthFile(object):
"""Helper class for handling testing of .pth files"""
Expand Down
3 changes: 3 additions & 0 deletions
3
Misc/NEWS
Original file line number
Diff line number
Diff line change
Expand Up
@@ -10,6 +10,9 @@ What's New in Python 3.7.0 alpha 1?
Core and Builtins
-----------------
- bpo-29779: New environment variable PYTHONHISTORY if
this is set you can change the location of a python_history file.
Comment thread
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more .
Please add "Patch by Your Name."
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
- bpo-28856: Fix an oversight that %b format for bytes should support objects
follow the buffer protocol.
Expand Down
Original file line number
Diff line number
Diff line change
Expand Up
@@ -431,6 +431,10 @@ values.
The integer must be a decimal number in the range [0,4294967295]. Specifying
the value 0 will disable hash randomization.
.IP PYTHONHISTORY
If this is set you can change the location of a
python_history file, by default it will be ~/.python_history.
Comment thread
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more .
File names should be italic in man pages so \fI~/.python_history\fI or
python_history file, by default it will be
.IR ~/.python_history . You may need to escape ~ or / characters.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
.SH AUTHOR
The Python Software Foundation: https://www.python.org/psf/
.SH INTERNET RESOURCES
Expand Down
Original file line number
Diff line number
Diff line change
Expand Up
@@ -105,7 +105,8 @@ static const char usage_6[] =
" predictable seed.\n"
"PYTHONMALLOC: set the Python memory allocators and/or install debug hooks\n"
" on Python memory allocators. Use PYTHONMALLOC=debug to install debug\n"
" hooks.\n";
" hooks.\n"
"PYTHONHISTORY: If this is set, you can change the location of a python_history file.\n";
Comment thread
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more .
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
static int
usage(int exitcode, const wchar_t* program)
Expand Down
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.