GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-13553: Document tkinter.Tk args by csabella · Pull Request #4786 · python/cpython

Conversation

@csabella

@csabella csabella commented Dec 11, 2017 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue13553

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@csabella
bpo-13553: Document tkinter.Tk args
fdc96ed
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Dec 11, 2017
@bedevere-bot bedevere-bot added the awaiting review label Dec 11, 2017
serhiy-storchaka
serhiy-storchaka reviewed Dec 11, 2017
View reviewed changes
Comment thread Doc/library/tkinter.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Doc/library/tkinter.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Doc/library/tkinter.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Doc/library/tkinter.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Doc/library/tkinter.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Doc/library/tkinter.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Doc/library/tkinter.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

@serhiy-storchaka
serhiy-storchaka requested a review from terryjreedy December 11, 2017 20:22
@csabella
Changes suggested by Serhiy.
35c6465
terryjreedy
terryjreedy requested changes Dec 12, 2017
View reviewed changes
Comment thread Doc/library/tkinter.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Doc/library/tkinter.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Doc/library/tkinter.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Doc/library/tkinter.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Doc/library/tkinter.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Doc/library/tkinter.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Doc/library/tkinter.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Doc/library/tkinter.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot

bedevere-bot commented Dec 12, 2017

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot added awaiting changes and removed awaiting review labels Dec 12, 2017
@terryjreedy

terryjreedy commented Dec 12, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

None of my comments are outdated by applying Serhiy's suggestions. My review just happened to start before the patch arrived, and except for 1, happen to be attached to the same sentences. Serhiy, please also review my comments.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka
serhiy-storchaka reviewed Dec 12, 2017
View reviewed changes
Comment thread Doc/library/tkinter.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Doc/library/tkinter.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Doc/library/tkinter.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Doc/library/tkinter.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Doc/library/tkinter.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

vstinner
vstinner reviewed Dec 12, 2017
View reviewed changes
Comment thread Doc/library/tkinter.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Doc/library/tkinter.rst
Specifies that the main window for the application is to be embedded in
the window whose identifier is given, instead of being created as an
independent toplevel window.

@vstinner vstinner Dec 12, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we are documenting the Tk class. Would it be worth it to document Tk attributes? master, children and tk.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@csabella csabella Dec 12, 2017

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current page reads more like a 'getting started' or 'how to', so I wasn't sure how much detail to add. I know there's a separate bug issue where Terry figured out the difference between master and parent, so maybe it would be worthwhile to include that here?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread Doc/library/tkinter.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

@csabella
Additional changes
df696bb
@csabella

csabella commented Dec 12, 2017

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot added awaiting change review and removed awaiting changes labels Dec 12, 2017
@bedevere-bot

bedevere-bot commented Dec 12, 2017

Copy link
Copy Markdown

Thanks for making the requested changes!

@terryjreedy: please review the changes made to this pull request.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vstinner
vstinner reviewed Dec 12, 2017
View reviewed changes
Comment thread Doc/library/tkinter.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

csabella added 2 commits December 14, 2017 18:21
@csabella
Add attributes and remove readprofile
0f468bc
@csabella
Modify readprofile docstring for file names.
c25db70
@csabella

csabella commented Dec 14, 2017

Copy link
Copy Markdown
Contributor Author

@terryjreedy @serhiy-storchaka @vstinner
I've made additional changes to document the attributes and to remove the documentation of readprofile. Thanks!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vstinner
vstinner reviewed Dec 15, 2017
View reviewed changes
Comment thread Doc/library/tkinter.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Doc/library/tkinter.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

vadmium
vadmium reviewed Dec 16, 2017
View reviewed changes
Comment thread Doc/library/tkinter.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

@csabella
Remove reference to C methods
9068406
terryjreedy
terryjreedy previously approved these changes Feb 2, 2018
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting change review labels Feb 2, 2018
@terryjreedy terryjreedy closed this Feb 2, 2018
@terryjreedy terryjreedy reopened this Feb 2, 2018
@vstinner

vstinner commented Jan 10, 2019

Copy link
Copy Markdown
Member

I removed the " needs backport to 3.6" label, the 3.6 branch no longer accept bugfixes (only security fixes are accepted): https://devguide.python.org/#status-of-python-branches

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@JulienPalard

JulienPalard commented Sep 13, 2019

Copy link
Copy Markdown
Member

@csabella Looks like this PR is almost OK, maybe just missing the mention that className permits to choose the title of the window (last message of Mark). I tried to mark as resolved every actually resolved comments, I'll let you read the rest of them a last time.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ned-deily ned-deily removed the needs backport to 3.7 label Jul 3, 2020
@JelleZijlstra
Merge branch 'main' into bpo13553
57553df
JelleZijlstra
JelleZijlstra approved these changes May 8, 2022
View reviewed changes

@JelleZijlstra JelleZijlstra left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, it seems the remaining comments don't need to be blocking.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@JelleZijlstra JelleZijlstra self-assigned this May 8, 2022
@JelleZijlstra JelleZijlstra added needs backport to 3.9 needs backport to 3.11 only security fixes labels May 8, 2022
@JelleZijlstra

JelleZijlstra commented May 8, 2022

Copy link
Copy Markdown
Member

Planning to merge this unless someone has further comments.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

taleinat
taleinat approved these changes May 9, 2022
View reviewed changes
@taleinat

taleinat commented May 9, 2022

Copy link
Copy Markdown
Contributor

LGTM

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

JulienPalard
JulienPalard approved these changes May 9, 2022
View reviewed changes
@JelleZijlstra
JelleZijlstra merged commit c56e2bb into python:main May 10, 2022
@miss-islington

miss-islington commented May 10, 2022

Copy link
Copy Markdown
Contributor

Thanks @csabella for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10, 3.11.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the awaiting merge label May 10, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 10, 2022
@csabella @miss-islington
bpo-13553: Document tkinter.Tk args (pythonGH-4786)
8d836f4
(cherry picked from commit c56e2bb)

Co-authored-by: Cheryl Sabella <[email protected]>
@bedevere-bot

bedevere-bot commented May 10, 2022

Copy link
Copy Markdown

GH-92593 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed needs backport to 3.11 only security fixes needs backport to 3.10 labels May 10, 2022
@bedevere-bot

bedevere-bot commented May 10, 2022

Copy link
Copy Markdown

GH-92594 is a backport of this pull request to the 3.10 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 10, 2022
@csabella @miss-islington
bpo-13553: Document tkinter.Tk args (pythonGH-4786)
e79711c
(cherry picked from commit c56e2bb)

Co-authored-by: Cheryl Sabella <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 label May 10, 2022
@bedevere-bot

bedevere-bot commented May 10, 2022

Copy link
Copy Markdown

GH-92595 is a backport of this pull request to the 3.9 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 10, 2022
@csabella @miss-islington
bpo-13553: Document tkinter.Tk args (pythonGH-4786)
cf1f27a
(cherry picked from commit c56e2bb)

Co-authored-by: Cheryl Sabella <[email protected]>
miss-islington added a commit that referenced this pull request May 10, 2022
@miss-islington @csabella
bpo-13553: Document tkinter.Tk args (GH-4786)
74c094d
(cherry picked from commit c56e2bb)

Co-authored-by: Cheryl Sabella <[email protected]>
miss-islington added a commit that referenced this pull request May 10, 2022
@miss-islington @csabella
bpo-13553: Document tkinter.Tk args (GH-4786)
b7a8786
(cherry picked from commit c56e2bb)

Co-authored-by: Cheryl Sabella <[email protected]>
miss-islington added a commit that referenced this pull request May 10, 2022
@miss-islington @csabella
bpo-13553: Document tkinter.Tk args (GH-4786)
5ed2f11
(cherry picked from commit c56e2bb)

Co-authored-by: Cheryl Sabella <[email protected]>
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@miss-islington @csabella @hello-adam
bpo-13553: Document tkinter.Tk args (pythonGH-4786)
d5b0a60
(cherry picked from commit c56e2bb)

Co-authored-by: Cheryl Sabella <[email protected]>
@hauntsaninja hauntsaninja mentioned this pull request Oct 29, 2022
Tkinter Tk args and Gnome Shell application name #57762
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments
@vadmium vadmium vadmium left review comments
@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments
@JulienPalard JulienPalard JulienPalard approved these changes
@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@terryjreedy terryjreedy terryjreedy left review comments
+2 more reviewers
@roseman roseman roseman left review comments
@taleinat taleinat taleinat approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@JelleZijlstra JelleZijlstra

Labels

docs Documentation in the Doc dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

13 participants

@csabella @bedevere-bot @terryjreedy @ned-deily @roseman @vstinner @JulienPalard @JelleZijlstra @taleinat @miss-islington @vadmium @serhiy-storchaka @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.