GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||||||||||
GeezerVison is showing github.com — bpo-13553: Document tkinter.Tk args by csabella · Pull Request #4786 · python/cpython Conversation
|
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
None of my comments are outdated by applying Serhiy's suggestions. My review just happened to start before the patch arrived, and except for 1, happen to be attached to the same sentences. Serhiy, please also review my comments. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
| Specifies that the main window for the application is to be embedded in | ||
| the window whose identifier is given, instead of being created as an | ||
| independent toplevel window. | ||
|
|
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
While we are documenting the Tk class. Would it be worth it to document Tk attributes? master, children and tk.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
The current page reads more like a 'getting started' or 'how to', so I wasn't sure how much detail to add. I know there's a separate bug issue where Terry figured out the difference between master and parent, so maybe it would be worthwhile to include that here?
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
I have made the requested changes; please review again. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks for making the requested changes! @terryjreedy: please review the changes made to this pull request. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
@terryjreedy @serhiy-storchaka @vstinner |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
I removed the " needs backport to 3.6" label, the 3.6 branch no longer accept bugfixes (only security fixes are accepted): https://devguide.python.org/#status-of-python-branches |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@csabella Looks like this PR is almost OK, maybe just missing the mention that |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Looks good, it seems the remaining comments don't need to be blocking.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Planning to merge this unless someone has further comments. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
LGTM |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks @csabella for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10, 3.11. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
(cherry picked from commit c56e2bb) Co-authored-by: Cheryl Sabella <[email protected]>
|
GH-92593 is a backport of this pull request to the 3.11 branch. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
GH-92594 is a backport of this pull request to the 3.10 branch. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
(cherry picked from commit c56e2bb) Co-authored-by: Cheryl Sabella <[email protected]>
|
GH-92595 is a backport of this pull request to the 3.9 branch. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
(cherry picked from commit c56e2bb) Co-authored-by: Cheryl Sabella <[email protected]>
(cherry picked from commit c56e2bb) Co-authored-by: Cheryl Sabella <[email protected]>
(cherry picked from commit c56e2bb) Co-authored-by: Cheryl Sabella <[email protected]>
(cherry picked from commit c56e2bb) Co-authored-by: Cheryl Sabella <[email protected]>
(cherry picked from commit c56e2bb) Co-authored-by: Cheryl Sabella <[email protected]>
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.