GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-32338: OrderedDict import is no longer needed in re. by serhiy-storchaka · Pull Request #4891 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Dec 15, 2017 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue32338

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
bpo-32338: OrderedDict import is no longer needed in re.
daf1b74
@serhiy-storchaka serhiy-storchaka added the skip news label Dec 15, 2017
@serhiy-storchaka
serhiy-storchaka requested a review from rhettinger December 15, 2017 18:25
@bedevere-bot bedevere-bot added the awaiting merge label Dec 15, 2017
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Dec 15, 2017
rhettinger
rhettinger approved these changes Dec 15, 2017
View reviewed changes
@methane methane mentioned this pull request Dec 26, 2017
bpo-32360: Remove OrderedDict from re module #5013
Closed
@serhiy-storchaka serhiy-storchaka added the needs backport to 3.7 label Mar 11, 2018
@serhiy-storchaka
serhiy-storchaka merged commit b931bd0 into python:master Mar 11, 2018
@miss-islington

miss-islington commented Mar 11, 2018

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Mar 11, 2018

Copy link
Copy Markdown

@serhiy-storchaka: Please replace # with GH- in the commit message next time. Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Mar 11, 2018
@serhiy-storchaka
serhiy-storchaka deleted the re-cache-regular-dict branch March 11, 2018 06:38
@bedevere-bot

bedevere-bot commented Mar 11, 2018

Copy link
Copy Markdown

GH-6073 is a backport of this pull request to the 3.7 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.7 label Mar 11, 2018
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 11, 2018
@serhiy-storchaka @miss-islington
bpo-32338: OrderedDict import is no longer needed in re. (pythonGH-4891)
2ba78dd 
(cherry picked from commit b931bd0)

Co-authored-by: Serhiy Storchaka <[email protected]>
miss-islington added a commit that referenced this pull request Mar 11, 2018
@miss-islington @serhiy-storchaka
bpo-32338: OrderedDict import is no longer needed in re. (GH-4891)
39441fc 
(cherry picked from commit b931bd0)

Co-authored-by: Serhiy Storchaka <[email protected]>
jo2y pushed a commit to jo2y/cpython that referenced this pull request Mar 23, 2018
@serhiy-storchaka @jo2y
bpo-32338: OrderedDict import is no longer needed in re. (python#4891)
198922b
@finefoot finefoot mentioned this pull request May 6, 2020
bpo-30256: Add test for nested queues #16341
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhettinger rhettinger rhettinger approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@serhiy-storchaka @miss-islington @bedevere-bot @rhettinger @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.