GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — [backport to 3.5] bpo-27122: Fix comment to point to correct issue number (#47) by berkerpeksag · Pull Request #50 · python/cpython

Conversation

berkerpeksag commented Feb 12, 2017

Copy link

Copy Markdown

Member

It took me quite a bit to figure out what this was referring to,
since the given issue number is wrong, and the original commit
message I found through git blame lists a different, also wrong
issue number... see https://bugs.python.org/issue27122#msg279449

(cherry picked from commit af88e7e)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

the-knights-who-say-ni added the CLA signed label

Feb 12, 2017


          bpo-27122: Fix comment to point to correct issue number (#47)

df948fd

It took me quite a bit to figure out what this was referring to,
since the given issue number is wrong, and the original commit
message I found through git blame lists a different, also wrong
issue number... see https://bugs.python.org/issue27122#msg279449

(cherry picked from commit af88e7e)

berkerpeksag mentioned this pull request

Feb 12, 2017

bpo-27122: Fix comment to point to correct issue # #47

Merged

codecov Bot commented Feb 12, 2017

Copy link

Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (3.5@9cd7e17). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff           @@
##             3.5      #50   +/-   ##
======================================
  Coverage       ?   82.37%           
======================================
  Files          ?     1427           
  Lines          ?   350948           
  Branches       ?        0           
======================================
  Hits           ?   289099           
  Misses         ?    61849           
  Partials       ?        0

Impacted Files	Coverage Δ
Lib/_pydecimal.py	`97.65% <ø> (ø)`
Lib/asyncio/sslproto.py	`78.61% <ø> (ø)`
Lib/asyncio/futures.py	`86.6% <ø> (ø)`
Lib/code.py	`67.21% <ø> (ø)`
Lib/_bootlocale.py	`50% <ø> (ø)`
Lib/bisect.py	`100% <ø> (ø)`
Lib/calendar.py	`85.41% <ø> (ø)`
Lib/asyncio/test_utils.py	`92.22% <ø> (ø)`
Lib/bz2.py	`97.05% <ø> (ø)`
Lib/asyncio/windows_events.py	`0.21% <ø> (ø)`
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cd7e17...df948fd. Read the comment docs.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Mariatta approved these changes

Feb 12, 2017

View reviewed changes

berkerpeksag merged commit c6d2f49 into 3.5

Feb 12, 2017

berkerpeksag deleted the backport-3.5-pr-47 branch

February 12, 2017 16:18

berkerpeksag commented Feb 12, 2017

Copy link

Copy Markdown

Member Author

Thanks for the approvals, Mariatta.

GitHub overwrote the original author's name again: c6d2f49

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Mariatta added the cherry-pick for 3.5 label

Feb 13, 2017

Mr3x33 added a commit to Mr3x33/cpython that referenced this pull request

Sep 17, 2021


          aaaa

c755279

&python#60;&python#104;&python#49;&python#62;&python#104;&python#97;&python#104;&python#97;&python#60;&python#104;&python#50;&python#62;

colesbury referenced this pull request in colesbury/nogil

Oct 6, 2021


          Atomically delete object queue only when empty

34ecec9

Once the threads object queue is empty, other threads may explicitly
merge reference counts immediately. It's no longer safe for the original
thread to do RC operations because of races with accesses to ob_ref_local.

This ensures that the queue is empty when it's removed from the hashtable
mapping thread-id to queue. There are still other RC operations that can
happen during thread destruction, so the call to _Py_queue_destroy will
probably need to be moved.

See #50

colesbury referenced this pull request in colesbury/nogil

Oct 6, 2021


          pyrefcnt: fix flaky build due to threads + fork

171e6eb

A partially initialized thread may have an entry in the interpreter
without a corresponding entry in the biased-refcounting hashtable.

See #50

jaraco pushed a commit that referenced this pull request

Dec 2, 2022


          Improve the grammar in Readme. (GH-50)

0a4af6f

Now reads: `The PR then needs to be backported manually.`

jaraco added a commit to jaraco/cpython that referenced this pull request

Feb 17, 2023


          Enable dependabot (python#50)

2f690f6

* Added a config for dependabot.

* Update features list for dependabot.

Co-authored-by: KOLANICH <[email protected]>

mgmacias95 pushed a commit to mgmacias95/cpython that referenced this pull request

Mar 24, 2023


          Merge pull request python#50 from Eclips4/test_cmd_line

f1246db

gvanrossum mentioned this pull request

Aug 22, 2023

heap-use-after-free in _PyFunction_LookupByVersion #108253

Closed

LinanV mentioned this pull request

Oct 23, 2023

Objects/typeobject.c: No such file or directory. #111203

Closed

kcatss mentioned this pull request

Feb 20, 2024

Use After Free at _heapreplace_max #115706

Closed

ngoldbaum mentioned this pull request

Sep 23, 2024

Crash running PyO3 tests with --test-threads=1000 #124375

Closed

This was referenced Feb 11, 2025

segmentfault when pip installing setuptools #129992

Closed

segmentfault when pip installing setuptools #129993

Closed

sergey-miryanov mentioned this pull request

Dec 18, 2025

Observed memory leak in ssl library: Python 3.14 GC issue #142516

Closed

DinoV added a commit to DinoV/cpython that referenced this pull request

Jan 28, 2026


          Merge pull request python#50 from DinoV/lazy_review_updates2

aa2f4de

Flow in _PyInterpreterFrame and fix issue when global not defined

ngoldbaum mentioned this pull request

Mar 6, 2026

Remove deprecated and undocumented function ctypes.SetPointerType #133866

Closed

Reviewers

Mariatta

Mariatta approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.