GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-29176: Fix name of the _curses.window class by vstinner · Pull Request #52 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Feb 12, 2017

Copy link
Copy Markdown
Member

Set name to "_curses.window" instead of "_curses.curses window" (with
a space!?).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
bpo-29176: Fix name of the _curses.window class
6f49906 
Set name to "_curses.window" instead of "_curses.curses window" (with
a space!?).
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 12, 2017
@codecov

codecov Bot commented Feb 12, 2017

Copy link
Copy Markdown

Codecov Report

Merging #52 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
+ Coverage   82.37%   82.37%   +<.01%     
==========================================
  Files        1427     1427              
  Lines      350948   350948              
==========================================
+ Hits       289093   289098       +5     
+ Misses      61855    61850       -5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c22bfaa...6f49906. Read the comment docs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
briancurtin
briancurtin reviewed Feb 12, 2017
View reviewed changes

@briancurtin briancurtin left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, trivial change

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
briancurtin
briancurtin approved these changes Feb 12, 2017
View reviewed changes

@briancurtin briancurtin left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, trivial change (actually approving now)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner

vstinner commented Feb 12, 2017

Copy link
Copy Markdown
Member Author

Serhiy Storshaka asked me if the change can have any impact on pickle. No, it doesn't because these objects were not picklable before and are not pickable after ;-)
http://bugs.python.org/issue29176#msg287521
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit 61e2bc7 into python:master Feb 12, 2017
@berkerpeksag berkerpeksag added the backport to 3.6 label Feb 13, 2017
Mariatta referenced this pull request in Mariatta/cpython Mar 7, 2017
@vstinner @Mariatta
bpo-29176: Fix name of the _curses.window class (#52)
51c864c 
Set name to "_curses.window" instead of "_curses.curses window" (with
a space!?).
(cherry picked from commit 61e2bc7)
@Mariatta Mariatta removed the needs backport to 3.6 label Mar 7, 2017
vstinner pushed a commit that referenced this pull request Mar 8, 2017
@Mariatta @vstinner
bpo-29176: Fix name of the _curses.window class (#52) (#532)
7253ade 
Set name to "_curses.window" instead of "_curses.curses window" (with
a space!?).
(cherry picked from commit 61e2bc7)
@vstinner
vstinner deleted the curses_fix_window_class_name branch June 15, 2017 23:02
colesbury referenced this pull request in colesbury/nogil Oct 6, 2021
@colesbury
Fix race in test_trashcan_threads in test_gc.py
eb97914 
See #52
jaraco pushed a commit that referenced this pull request Dec 2, 2022
@Mariatta
Fix the pull_request_review webhook. (#52)
aec8995
jaraco pushed a commit to jaraco/cpython that referenced this pull request Feb 17, 2023
@warsaw
Merge branch 'issue52' into 'master'
59bf56e 
Backport bpo-33254 - contents() returns an Iterable

Closes python#52

See merge request python-devs/importlib_resources!57
isidentical pushed a commit to isidentical/cpython that referenced this pull request Mar 28, 2023
@pablogsal
Merge pull request python#52 from isidentical/last-fstring-status
a0edfb1
oraluben pushed a commit to oraluben/cpython that referenced this pull request Jul 12, 2023
@JuliaPoo @Fidget-Spinner @brandtbucher
Feat: Merge Brandt's Copy and Patch compiler (python#52)
a6533c1 
Co-authored-by: Ken Jin <[email protected]>
Co-authored-by: Brandt Bucher <[email protected]>
@gvanrossum gvanrossum mentioned this pull request Aug 22, 2023
heap-use-after-free in _PyFunction_LookupByVersion #108253
Closed
@LinanV LinanV mentioned this pull request Oct 23, 2023
Objects/typeobject.c: No such file or directory. #111203
Closed
@kcatss kcatss mentioned this pull request Feb 20, 2024
Use After Free at _heapreplace_max #115706
Closed
@ngoldbaum ngoldbaum mentioned this pull request Sep 23, 2024
Crash running PyO3 tests with --test-threads=1000 #124375
Closed
This was referenced Feb 11, 2025
segmentfault when pip installing setuptools #129992
Closed
segmentfault when pip installing setuptools #129993
Closed
@sergey-miryanov sergey-miryanov mentioned this pull request Dec 18, 2025
Observed memory leak in ssl library: Python 3.14 GC issue #142516
Closed
@ngoldbaum ngoldbaum mentioned this pull request Mar 6, 2026
Remove deprecated and undocumented function ctypes.SetPointerType #133866
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@briancurtin briancurtin briancurtin approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@vstinner @briancurtin @berkerpeksag @Mariatta @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.