GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.6] Fix changed file detection on Travis (GH-3129) by miss-islington · Pull Request #5365 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jan 27, 2018

Copy link
Copy Markdown
Contributor

Travis when merging changes from a pull request onto the target branch
does not perform a rebase, instead it does a simple merge which causes
the PR commits to retain their commit dates. This means that the commit
log can potentially look like:

PR merge <-- HEAD
normal master commit <- master
more commits from normal workflow
PR commit 1
another master commit
PR commit 2

Performing a git diff from PR commit 2 to master will accidentally
include files that should not be there.

Closes python/core-workflowGH-14
(cherry picked from commit b2ec361)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ammaraskar @miss-islington
Fix changed file detection on Travis (pythonGH-3129)
130cd28
Travis when merging changes from a pull request onto the target branch
does not perform a rebase, instead it does a simple merge which causes
the PR commits to retain their commit dates. This means that the commit
log can potentially look like:

PR merge <-- HEAD
normal master commit <- master
more commits from normal workflow
PR commit 1
another master commit
PR commit 2

Performing a git diff from PR commit 2 to master will accidentally
include files that should not be there.

Closes python/core-workflowGH-14
(cherry picked from commit b2ec361)
@bedevere-bot bedevere-bot added skip issue skip news labels Jan 27, 2018
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jan 27, 2018
@bedevere-bot bedevere-bot mentioned this pull request Jan 27, 2018
Fix changed file detection on travis when the PR commits predate master commits. #3129
Merged
@bedevere-bot bedevere-bot added the awaiting review label Jan 27, 2018
@miss-islington

miss-islington commented Jan 27, 2018

Copy link
Copy Markdown
Contributor Author

@ammaraskar and @berkerpeksag: Backport status check is done, and it's a success ✅ .

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@berkerpeksag
berkerpeksag merged commit 4d2dd64 into python:3.6 Jan 27, 2018
@miss-islington

miss-islington commented Jan 27, 2018

Copy link
Copy Markdown
Contributor Author

Thanks, @berkerpeksag!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the awaiting review label Jan 27, 2018
@miss-islington
miss-islington deleted the backport-b2ec361-3.6 branch January 27, 2018 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@miss-islington @berkerpeksag @the-knights-who-say-ni @bedevere-bot @ammaraskar
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.