GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — bpo-29514: Check magic number for bugfix release by appeltel · Pull Request #54 · python/cpython

Conversation

appeltel commented Feb 12, 2017 •

edited by ncoghlan

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Add a test to check the current MAGIC_NUMBER against the
expected number for the release if the current release is
at candidate or final level. On test failure, describe to
the developer the procedure for changing the magic number.

https://bugs.python.org/issue29514

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ncoghlan reacted with hooray emoji

All reactions

🎉 1 reaction


          bpo-29514: Check magic number for micro release

51835c7

Add a dict importlib.util.EXPECTED_MAGIC_NUMBERS which
details the initial and expected pyc magic number for
each minor release. This gives a mechanism for users to
check if the magic number has changed within a release and
for a test to ensure procedure is followed if a change is
necessary.

Add a test to check the current MAGIC_NUMBER against the
expected number for the release if the current release is
at candidate or final level. On test failure, describe to
the developer the procedure for changing the magic number.

the-knights-who-say-ni added the CLA signed label

Feb 12, 2017

ncoghlan requested changes

Feb 12, 2017

View reviewed changes

ncoghlan left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The general approach in the test case looks like it will give affected maintainers useful guidance, but the impact can be reduced by moving the EXPECTED_MAGIC_NUMBERS table into the test case itself (the test case will complain when it needs updating, so it's OK to have it separated from the list of actual magic numbers in the importlib code)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Lib/importlib/_bootstrap_external.py Outdated

		(2, 7): 62211,
		(3, 5): 3350,
		(3, 6): 3379
		}

ncoghlan Feb 12, 2017

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd put this table in the test suite rather than in the code - there's no need to have it other than the bytecode stability test case, and if it hasn't been updated when it needs to be we'll get a test failure anyway.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

appeltel Mar 11, 2017

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplifed to a sigle entry in the test case in 9ea7c52

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Lib/importlib/util.py Outdated

		from ._bootstrap import _resolve_name
		from ._bootstrap import spec_from_loader
		from ._bootstrap import _find_spec
		from ._bootstrap_external import EXPECTED_MAGIC_NUMBERS

ncoghlan Feb 12, 2017

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the table moved to the test suite, this won't be needed any more.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

appeltel Mar 11, 2017

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed in 9ea7c52

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Lib/test/test_importlib/test_release.py Outdated


		In exceptional cases, it may be required to change the MAGIC_NUMBER
		for a maintenance release. In this case the change should be
		discussed in dev-python. If a change is required, community

ncoghlan Feb 12, 2017

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dev-python -> python-dev

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

appeltel Mar 11, 2017

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 9ea7c52

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

ambv reviewed

Feb 13, 2017

View reviewed changes

Comment thread

Lib/importlib/_bootstrap_external.py Outdated


		EXPECTED_MAGIC_NUMBERS = {
		(2, 7): 62211,
		(3, 5): 3350,

ambv Feb 13, 2017

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean we're reverting the magic number bump from 3.5.3?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

ncoghlan Feb 13, 2017

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, but the current special case from the test should just be moved directly into the table of expected magic numbers with a suitable comment.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Simplify magic number release test

9ea7c52

Simplify the magic number release test by removing
EXPECTED_MAGIC_NUMBERS table and making the expected
magic number self-contained within the test.

BPO: 29514

ncoghlan requested changes

Mar 12, 2017

View reviewed changes

ncoghlan left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking pretty close now, just a couple of suggestions around details of the test execution.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Lib/test/test_importlib/test_util.py Outdated

		) = util.test_both(PEP3147Tests, util=importlib_util)


		class MagicNumberTests:

ncoghlan Mar 12, 2017

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inherit from unittest.TestCase here

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

appeltel Mar 12, 2017

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I initially avoided this and followed the test machinery as I wasn't sure about directly importing importlib.util within this test module, but after looking at the way the test specialization works I don't see how this is an issue. Changed in 1e32a1b.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

ncoghlan Mar 13, 2017

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this module does some interesting things to create "real" test classes in different configurations, but we don't need those kinds of tricks for the new test.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Lib/test/test_importlib/test_util.py Outdated

		adjustment to this test case.
		"""
		if sys.version_info.releaselevel not in ('final', 'candidate'):
		return

ncoghlan Mar 12, 2017

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can change to a unittest.skipUnless decorator on the testmethod:

@unittest.skipUnless(sys.version_info.release in ('final', 'release'), 'Only check magic number stability for release candidates and later')

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

appeltel Mar 12, 2017

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 1e32a1b

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Lib/test/test_importlib/test_util.py Outdated

		actual = int.from_bytes(self.util.MAGIC_NUMBER[:2], 'little')

		msg = (
		"Candidate and final releases require the current "

ncoghlan Mar 12, 2017

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd start this message with "To avoid breaking backwards compatibility with cached bytecode files that can't be automatically regenerated by the current user, ..."

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

appeltel Mar 12, 2017

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in 1e32a1b

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Improve magic number test execution and message

1e32a1b

Improve the execution of the magic number test by
using skipUnless for alpha and beta releases, and
directly inheriting from unittest.TestCase rather than
using the machinery for the other tests. Also improve
the error message to explain the reason for caution in
changing the magic number.

BPO: 29514

codecov Bot commented Mar 12, 2017

Copy link

Copy Markdown

Codecov Report

Merging #54 into master will decrease coverage by <.01%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
- Coverage   82.37%   82.37%   -0.01%     
==========================================
  Files        1427     1428       +1     
  Lines      350948   350968      +20     
==========================================
+ Hits       289093   289102       +9     
- Misses      61855    61866      +11

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c22bfaa...1e32a1b. Read the comment docs.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ncoghlan approved these changes

Mar 13, 2017

View reviewed changes

ncoghlan added needs backport to 2.7 labels

Mar 13, 2017

serhiy-storchaka reviewed

Apr 2, 2017

View reviewed changes

Comment thread

Lib/test/test_importlib/test_util.py

		actual = int.from_bytes(importlib.util.MAGIC_NUMBER[:2], 'little')

		msg = (
		"To avoid breaking backwards compatibility with cached bytecode "

serhiy-storchaka Apr 2, 2017

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't be better to use a multiline string literal if you want such verbose error message?

But I think that "broken *.pyc files compatibility" would be enough.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

ambv Apr 17, 2017

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then you'd have to dedent it, etc. This message is perfectly legible to me.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

serhiy-storchaka reviewed

Apr 2, 2017

View reviewed changes

Comment thread

Lib/test/test_importlib/test_util.py

		)
		def test_magic_number(self):
		"""
		Each python minor release should generally have a MAGIC_NUMBER

serhiy-storchaka Apr 2, 2017

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to write this as a comment rather than a docstring. If you want, add a one-line docstring, but most test methods don't have docstrings.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

ambv merged commit d6d344d into python:master

Apr 17, 2017

Mariatta added needs backport to 3.6 and removed needs backport to 3.6 labels

Sep 7, 2017

miss-islington commented Sep 7, 2017

Copy link

Copy Markdown

Contributor

🐍🍒⛏🤖 Thanks @appeltel for the PR, and @ambv for merging it 🌮🎉.I'm working now to backport this PR to: 2.7, 3.6.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington commented Sep 7, 2017

Copy link

Copy Markdown

Contributor

Sorry @appeltel and @ambv, I had trouble checking out the 3.6 backport branch.
Please backport using cherry_picker on command line.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington commented Sep 7, 2017

Copy link

Copy Markdown

Contributor

Sorry, @appeltel and @ambv, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ncoghlan removed needs backport to 2.7 labels

Sep 7, 2017

ncoghlan commented Sep 7, 2017

Copy link

Copy Markdown

Contributor

This was backported a while back, but I missed updating the labels:

2.7:#2160
3.5: #2158
3.6: #2157

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

lazka added a commit to lazka/cpython that referenced this pull request

Nov 10, 2021


          distutils: remove checks for ancient gcc/binutils

a69be8f

The versions checked here are 20 years old. Also dllwrap
has started to emit a deprecation warning in the latest release
spamming the build logs.

Fixes python#54

lazka added a commit to lazka/cpython that referenced this pull request

Nov 21, 2021


          distutils: remove checks for ancient gcc/binutils

8ec77b6

The versions checked here are 20 years old. Also dllwrap
has started to emit a deprecation warning in the latest release
spamming the build logs.

Fixes python#54

naveen521kk pushed a commit to naveen521kk/cpython that referenced this pull request

Jan 23, 2022


          distutils: remove checks for ancient gcc/binutils

d25b393

The versions checked here are 20 years old. Also dllwrap
has started to emit a deprecation warning in the latest release
spamming the build logs.

Fixes python#54

naveen521kk pushed a commit to naveen521kk/cpython that referenced this pull request

Dec 8, 2022


          distutils: remove checks for ancient gcc/binutils

f359056

The versions checked here are 20 years old. Also dllwrap
has started to emit a deprecation warning in the latest release
spamming the build logs.

Fixes python#54

lazka added a commit to lazka/cpython that referenced this pull request

Mar 2, 2023


          distutils: remove checks for ancient gcc/binutils

7e1d329

The versions checked here are 20 years old. Also dllwrap
has started to emit a deprecation warning in the latest release
spamming the build logs.

Fixes python#54

mgmacias95 pushed a commit to mgmacias95/cpython that referenced this pull request

Mar 27, 2023


          Merge pull request python#54 from sunmy2019/handle-invalid-expressions

30ea09f

lazka added a commit to lazka/cpython that referenced this pull request

Apr 7, 2023


          distutils: remove checks for ancient gcc/binutils

3a04da2

The versions checked here are 20 years old. Also dllwrap
has started to emit a deprecation warning in the latest release
spamming the build logs.

Fixes python#54

lazka added a commit to lazka/cpython that referenced this pull request

Apr 16, 2023


          distutils: remove checks for ancient gcc/binutils

dc6119e

The versions checked here are 20 years old. Also dllwrap
has started to emit a deprecation warning in the latest release
spamming the build logs.

Fixes python#54

naveen521kk pushed a commit to naveen521kk/cpython that referenced this pull request

Jun 18, 2023


          distutils: remove checks for ancient gcc/binutils

8d7310b

The versions checked here are 20 years old. Also dllwrap
has started to emit a deprecation warning in the latest release
spamming the build logs.

Fixes python#54

naveen521kk pushed a commit to naveen521kk/cpython that referenced this pull request

Jun 20, 2023


          distutils: remove checks for ancient gcc/binutils

The versions checked here are 20 years old. Also dllwrap
has started to emit a deprecation warning in the latest release
spamming the build logs.

Fixes python#54

naveen521kk pushed a commit to naveen521kk/cpython that referenced this pull request

Jun 23, 2023


          distutils: remove checks for ancient gcc/binutils

3f827c8

The versions checked here are 20 years old. Also dllwrap
has started to emit a deprecation warning in the latest release
spamming the build logs.

Fixes python#54

naveen521kk pushed a commit to naveen521kk/cpython that referenced this pull request

Jun 23, 2023


          distutils: remove checks for ancient gcc/binutils

4f65c1e

The versions checked here are 20 years old. Also dllwrap
has started to emit a deprecation warning in the latest release
spamming the build logs.

Fixes python#54

naveen521kk pushed a commit to naveen521kk/cpython that referenced this pull request

Jun 23, 2023


          distutils: remove checks for ancient gcc/binutils

86e3d50

The versions checked here are 20 years old. Also dllwrap
has started to emit a deprecation warning in the latest release
spamming the build logs.

Fixes python#54

naveen521kk pushed a commit to naveen521kk/cpython that referenced this pull request

Jun 23, 2023


          distutils: remove checks for ancient gcc/binutils

abb666c

The versions checked here are 20 years old. Also dllwrap
has started to emit a deprecation warning in the latest release
spamming the build logs.

Fixes python#54

naveen521kk pushed a commit to naveen521kk/cpython that referenced this pull request

Jun 23, 2023


          distutils: remove checks for ancient gcc/binutils

c6a75f1

The versions checked here are 20 years old. Also dllwrap
has started to emit a deprecation warning in the latest release
spamming the build logs.

Fixes python#54

naveen521kk pushed a commit to naveen521kk/cpython that referenced this pull request

Jun 23, 2023


          distutils: remove checks for ancient gcc/binutils

The versions checked here are 20 years old. Also dllwrap
has started to emit a deprecation warning in the latest release
spamming the build logs.

Fixes python#54

naveen521kk pushed a commit to naveen521kk/cpython that referenced this pull request

Jun 23, 2023


          distutils: remove checks for ancient gcc/binutils

d0b2083

The versions checked here are 20 years old. Also dllwrap
has started to emit a deprecation warning in the latest release
spamming the build logs.

Fixes python#54

naveen521kk pushed a commit to naveen521kk/cpython that referenced this pull request

Jun 23, 2023


          distutils: remove checks for ancient gcc/binutils

7726bf7

The versions checked here are 20 years old. Also dllwrap
has started to emit a deprecation warning in the latest release
spamming the build logs.

Fixes python#54

naveen521kk pushed a commit to naveen521kk/cpython that referenced this pull request

Jun 24, 2023


          distutils: remove checks for ancient gcc/binutils

1f016b6

The versions checked here are 20 years old. Also dllwrap
has started to emit a deprecation warning in the latest release
spamming the build logs.

Fixes python#54

naveen521kk pushed a commit to naveen521kk/cpython that referenced this pull request

Jun 25, 2023


          distutils: remove checks for ancient gcc/binutils

4d86299

The versions checked here are 20 years old. Also dllwrap
has started to emit a deprecation warning in the latest release
spamming the build logs.

Fixes python#54

oraluben pushed a commit to oraluben/cpython that referenced this pull request

Jul 12, 2023


          feat(ci): cache llvm installs across CI (python#54)

454b349

lazka added a commit to lazka/cpython that referenced this pull request

Jul 28, 2023


          distutils: remove checks for ancient gcc/binutils

075b6df

The versions checked here are 20 years old. Also dllwrap
has started to emit a deprecation warning in the latest release
spamming the build logs.

Fixes python#54

gvanrossum mentioned this pull request

Aug 22, 2023

heap-use-after-free in _PyFunction_LookupByVersion #108253

Closed

lazka added a commit to lazka/cpython that referenced this pull request

Aug 27, 2023


          distutils: remove checks for ancient gcc/binutils

b77c8c9

The versions checked here are 20 years old. Also dllwrap
has started to emit a deprecation warning in the latest release
spamming the build logs.

Fixes python#54

LinanV mentioned this pull request

Oct 23, 2023

Objects/typeobject.c: No such file or directory. #111203

Closed

lazka added a commit to lazka/cpython that referenced this pull request

Feb 10, 2024


          distutils: remove checks for ancient gcc/binutils

59319ba

The versions checked here are 20 years old. Also dllwrap
has started to emit a deprecation warning in the latest release
spamming the build logs.

Fixes python#54

kcatss mentioned this pull request

Feb 20, 2024

Use After Free at _heapreplace_max #115706

Closed

lazka added a commit to lazka/cpython that referenced this pull request

Aug 25, 2024


          distutils: remove checks for ancient gcc/binutils

bc6088b

The versions checked here are 20 years old. Also dllwrap
has started to emit a deprecation warning in the latest release
spamming the build logs.

Fixes python#54

ngoldbaum mentioned this pull request

Sep 23, 2024

Crash running PyO3 tests with --test-threads=1000 #124375

Closed

This was referenced Feb 11, 2025

segmentfault when pip installing setuptools #129992

Closed

segmentfault when pip installing setuptools #129993

Closed

sergey-miryanov mentioned this pull request

Dec 18, 2025

Observed memory leak in ssl library: Python 3.14 GC issue #142516

Closed

ngoldbaum mentioned this pull request

Mar 6, 2026

Remove deprecated and undocumented function ctypes.SetPointerType #133866

Closed

Reviewers

ambv

ambv left review comments

serhiy-storchaka

serhiy-storchaka left review comments

ncoghlan

ncoghlan approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

Conversation

appeltel commented Feb 12, 2017 • edited by ncoghlan Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ncoghlan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ncoghlan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Mar 12, 2017

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

miss-islington commented Sep 7, 2017

Uh oh!

miss-islington commented Sep 7, 2017

Uh oh!

miss-islington commented Sep 7, 2017

Uh oh!

ncoghlan commented Sep 7, 2017

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

appeltel commented Feb 12, 2017 •

edited by ncoghlan

Loading

Uh oh!

There was an error while loading. Please reload this page.