GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-32604: Fix memory leaks in the new _xxsubinterpreters module. by ericsnowcurrently · Pull Request #5507 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Feb 3, 2018 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This also fixes the 2 coverity-reported defects.

https://bugs.python.org/issue32604

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ericsnowcurrently added 19 commits February 3, 2018 04:23
@ericsnowcurrently
DECREF cls in _PyCrossInterpreterData_Lookup().
e12d641
@ericsnowcurrently
DECREF the id in interp_list_all().
ce72eef
@ericsnowcurrently
Avoid raising RunFailedError.
27bbab7
@ericsnowcurrently
DECREF id in _coerce_id().
c744873
@ericsnowcurrently
DECREF the original error message.
e982d87
@ericsnowcurrently
Do not explicitly check against INT64_MAX.
aac9485
@ericsnowcurrently
Free cids when done.
35f6046
@ericsnowcurrently
DECREF other in channelid_richcompare().
38d924e
@ericsnowcurrently
Add items to non-empty channels.
4321ecf
@ericsnowcurrently
Add struct _sharedns and isolate related memory ops.
e5a3515
@ericsnowcurrently
Clean up memory ops for _sharedexception.
0c0fa3d
@ericsnowcurrently
Clean up _PyChannelState memory ops.
f0d4430
@ericsnowcurrently
Add _channelref_free().
4802046
@ericsnowcurrently
Move the RunFailedError definition down.
ac7bad5
@ericsnowcurrently
Do not INCREF after PyErr_Fetch().
0689a9c
@ericsnowcurrently
DECREF the exception name.
9a91a28
@ericsnowcurrently
Free the channel when we close it.
654e59a
@ericsnowcurrently
Free the data when we are done with it.
8ca3c96
@ericsnowcurrently
DECREF the ID in channelid_hash().
702876b
@ericsnowcurrently ericsnowcurrently added the skip news label Feb 3, 2018
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 3, 2018
@bedevere-bot bedevere-bot added the awaiting merge label Feb 3, 2018
@ericsnowcurrently
ericsnowcurrently merged commit 4e9da0d into python:master Feb 3, 2018
@bedevere-bot

bedevere-bot commented Feb 3, 2018

Copy link
Copy Markdown

@ericsnowcurrently: Please replace # with GH- in the commit message next time. Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 3, 2018
@ericsnowcurrently
ericsnowcurrently deleted the fix-refleaks-interpreters-module branch February 3, 2018 04:49
@ericsnowcurrently ericsnowcurrently added the needs backport to 3.7 label Feb 3, 2018
@miss-islington

miss-islington commented Feb 3, 2018

Copy link
Copy Markdown
Contributor

Thanks @ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Feb 3, 2018

Copy link
Copy Markdown

GH-5509 is a backport of this pull request to the 3.7 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.7 label Feb 3, 2018
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 3, 2018
@ericsnowcurrently @miss-islington
bpo-32604: Fix memory leaks in the new _xxsubinterpreters module. (py…
baa9fd9 
…thonGH-5507)

(cherry picked from commit 4e9da0d)

Co-authored-by: Eric Snow <[email protected]>
ericsnowcurrently added a commit that referenced this pull request Feb 3, 2018
@miss-islington @ericsnowcurrently
bpo-32604: Fix memory leaks in the new _xxsubinterpreters module. (GH…
f33eced 
…-5507)

(cherry picked from commit 4e9da0d)

Co-authored-by: Eric Snow <[email protected]>
@ericsnowcurrently ericsnowcurrently mentioned this pull request Aug 24, 2018
memory leaks (coverity) ericsnowcurrently/multi-core-python#3
Closed
@ericsnowcurrently ericsnowcurrently mentioned this pull request Apr 10, 2022
[subinterpreters] PEP 554 implementation: add interpreters module #76785
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@ericsnowcurrently @bedevere-bot @miss-islington @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.