GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.7] bpo-32604: Make _xxsubinterpreters build on Windows (GH-5516) by miss-islington · Pull Request #5624 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Feb 11, 2018 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This is not the ideal solution; this means that a test module is now
always included in the main python3x.dll. However, we're already
including xxsubtype, so why not?
(cherry picked from commit 310b052)

Co-authored-by: Zachary Ware [email protected]

https://bugs.python.org/issue32604

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@zware @miss-islington
bpo-32604: Make _xxsubinterpreters build on Windows (pythonGH-5516)
af5d2df 
This is not the ideal solution; this means that a test module is now
always included in the main python3x.dll.  However, we're already
including xxsubtype, so why not?
(cherry picked from commit 310b052)

Co-authored-by: Zachary Ware <[email protected]>
@miss-islington
miss-islington requested a review from a team as a code owner February 11, 2018 16:44
@bedevere-bot bedevere-bot added the skip news label Feb 11, 2018
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 11, 2018
@bedevere-bot bedevere-bot mentioned this pull request Feb 11, 2018
bpo-32604: Make _xxsubinterpreters build on Windows #5516
Merged
@bedevere-bot bedevere-bot added the awaiting review label Feb 11, 2018
@miss-islington

miss-islington commented Feb 11, 2018

Copy link
Copy Markdown
Contributor Author

@zware: Backport status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zware
zware merged commit fe61e8d into python:3.7 Feb 11, 2018
@miss-islington

miss-islington commented Feb 11, 2018

Copy link
Copy Markdown
Contributor Author

Thanks, @zware!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting review label Feb 11, 2018
@miss-islington
miss-islington deleted the backport-310b052-3.7 branch February 11, 2018 17:16
@ericsnowcurrently ericsnowcurrently mentioned this pull request Apr 10, 2022
[subinterpreters] PEP 554 implementation: add interpreters module #76785
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @zware @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.