GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-32604: Make _xxsubinterpreters build on Windows by zware · Pull Request #5516 · python/cpython

Conversation

@zware

@zware zware commented Feb 3, 2018 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This is not the ideal solution; this means that a test module is now
always included in the main python3x.dll. However, we're already
including xxsubtype, so why not? It at least gets the code tested.

https://bugs.python.org/issue32604

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@zware
bpo-32604: Make _xxsubinterpreters build on Windows
6d5fa8f 
This is not the ideal solution; this means that a test module is now
always included in the main python3x.dll.  However, we're already
including xxsubtype, so why not?
@zware zware added OS-windows skip news needs backport to 3.7 labels Feb 3, 2018
@zware
zware requested review from ericsnowcurrently and zooba February 3, 2018 20:23
@zware
zware requested a review from a team as a code owner February 3, 2018 20:23
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 3, 2018
@bedevere-bot bedevere-bot added the awaiting merge label Feb 3, 2018
@zware
zware merged commit 310b052 into python:master Feb 11, 2018
@miss-islington

miss-islington commented Feb 11, 2018

Copy link
Copy Markdown
Contributor

Thanks @zware for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 11, 2018
@zware
zware deleted the temp_add_xxsubinterpreters branch February 11, 2018 16:43
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 11, 2018
@zware @miss-islington
bpo-32604: Make _xxsubinterpreters build on Windows (pythonGH-5516)
af5d2df 
This is not the ideal solution; this means that a test module is now
always included in the main python3x.dll.  However, we're already
including xxsubtype, so why not?
(cherry picked from commit 310b052)

Co-authored-by: Zachary Ware <[email protected]>
@bedevere-bot

bedevere-bot commented Feb 11, 2018

Copy link
Copy Markdown

GH-5624 is a backport of this pull request to the 3.7 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.7 label Feb 11, 2018
@zware zware mentioned this pull request Feb 11, 2018
bpo-32604: Add the _xxsubinterpreters extension module under Windows. #5436
Closed
@ericsnowcurrently ericsnowcurrently mentioned this pull request Aug 24, 2018
add Windows build support ericsnowcurrently/multi-core-python#5
Closed
@ericsnowcurrently ericsnowcurrently mentioned this pull request Apr 10, 2022
[subinterpreters] PEP 554 implementation: add interpreters module #76785
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently
@zooba zooba Awaiting requested review from zooba

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

OS-windows skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@zware @miss-islington @bedevere-bot @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.