GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix the only non-C90 comment to be C90 compatible. by ndparker · Pull Request #566 · python/cpython

Conversation

@ndparker

@ndparker ndparker commented Mar 8, 2017

Copy link
Copy Markdown
Contributor

Including pyport.h into a module compiled with a C89/90 compiler gives the error:

C++ style comments are not allowed in ISO C90.

It would be nice to be included into the next python 3.6 version as well.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ndparker
Fix the only non-C90 comment to be C90 compatible.
0efb2e6
@the-knights-who-say-ni

the-knights-who-say-ni commented Mar 8, 2017

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA. This is necessary for legal reasons before we can look at your contribution. Please follow these steps to help rectify the issue:

  1. If you don't have an account on b.p.o, please create one
  2. Make sure your GitHub username is listed in "Your Details" at b.p.o
  3. If you have not already done so, please sign the PSF contributor agreement. The "bugs.python.org username " requested by the form is the "Login name" field under "Your Details".
  4. If you just signed the CLA, please wait at least one US business day and then check "Your Details" on bugs.python.org to see if your account has been marked as having signed the CLA (the delay is due to a person having to manually check your signed CLA)
  5. Reply here saying you have completed the above steps

Thanks again to your contribution and we look forward to looking at it!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@the-knights-who-say-ni the-knights-who-say-ni added the CLA not signed label Mar 8, 2017
@mention-bot

mention-bot commented Mar 8, 2017

Copy link
Copy Markdown

@ndparker, thanks for your PR! By analyzing the history of the files in this pull request, we identified @benjaminp, @tim-one, @Yhg1s, @mdickinson and @mhammond to be potential reviewers.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error needs backport to 3.6 labels Mar 8, 2017
serhiy-storchaka
serhiy-storchaka approved these changes Mar 8, 2017
View reviewed changes
@serhiy-storchaka
serhiy-storchaka merged commit f7eda38 into python:master Mar 8, 2017
@serhiy-storchaka

serhiy-storchaka commented Mar 8, 2017

Copy link
Copy Markdown
Member

Could you please backport this change to 3.6 @ndparker?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ndparker

ndparker commented Mar 8, 2017

Copy link
Copy Markdown
Contributor Author

FWIW, I've signed the CLA now :-)

@serhiy-storchaka Thanks for merging. Should I open another PR for python 3.6 or how is it supposed to be done?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@serhiy-storchaka

serhiy-storchaka commented Mar 8, 2017

Copy link
Copy Markdown
Member

Thanks @ndparker. Signing the CLA for such trivial change is not needed, but i hope this is not your last contribution.

Just open another PR for Python 3.6.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ndparker ndparker mentioned this pull request Mar 8, 2017
Fix the only non-C90 comment to be C90 compatible. #568
Merged
@Mariatta Mariatta removed the needs backport to 3.6 label Mar 9, 2017
@Mariatta Mariatta removed the CLA not signed label Aug 30, 2018
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Aug 30, 2018
@vstinner vstinner mentioned this pull request Mar 20, 2024
PEP 7: Require -Werror=declaration-after-statement python/peps#3728
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@ndparker @the-knights-who-say-ni @mention-bot @serhiy-storchaka @Mariatta
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.