GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix the only non-C90 comment to be C90 compatible. by ndparker · Pull Request #568 · python/cpython

Conversation

@ndparker

@ndparker ndparker commented Mar 8, 2017

Copy link
Copy Markdown
Contributor

This is a follow up to #566

(Python 3.6 backport)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ndparker
Fix the only non-C90 comment to be C90 compatible.
152ee97
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 8, 2017
@serhiy-storchaka serhiy-storchaka added the cherry-pick for 3.6 label Mar 8, 2017
serhiy-storchaka
serhiy-storchaka approved these changes Mar 8, 2017
View reviewed changes
@serhiy-storchaka

serhiy-storchaka commented Mar 8, 2017

Copy link
Copy Markdown
Member

@ned-deily, I think it would be nice to include this simple change in 3.6.1.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka
serhiy-storchaka merged commit 51b646a into python:3.6 Mar 8, 2017
ned-deily pushed a commit to ned-deily/cpython that referenced this pull request Mar 21, 2017
@ndparker @ned-deily
Fix the only non-C90 comment to be C90 compatible. (python#568)
07e6cbd 
(cherry picked from commit 51b646a)
telamonian added a commit to telamonian/python-cmake-buildsystem that referenced this pull request Sep 17, 2020
@telamonian
Fix python-cmake-buildsystem#269: add C99 flag for intel compilers
b9354ae 
The intel C compiler [defaults to `-std=gnu98`](https://software.intel.com/content/www/us/en/develop/documentation/cpp-compiler-developer-guide-and-reference/top/compiler-reference/compiler-options/compiler-option-details/language-options/std-qstd.html#std-qstd_GUID-338F4C2A-560C-4338-8ACF-C4B022A7C865), which apparently causes problems with recent cpython source. Judging by the existing code in `CMakeLists.txt` and [this issue on the core cpython repo](python/cpython#568), somewhere around cpy3.6 cpython moved on to C99.

This PR ensures that if intel compilers are being used on cpy>=3.6 source, the `-std=C99` flag will be added
@telamonian telamonian mentioned this pull request Sep 17, 2020
Fix #269: add C99 flag for intel compilers python-cmake-buildsystem/python-cmake-buildsystem#271
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ndparker @serhiy-storchaka @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.