GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — bpo-19675: Fixes pool cleanup issue by dsoprea · Pull Request #57 · python/cpython

bpo-19675: Fixes pool cleanup issue #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

dsoprea wants to merge 1 commit into python:master from dsoprea:fix_multiprocessing_cleanup

Uh oh!

There was an error while loading. Please reload this page.

Closed

bpo-19675: Fixes pool cleanup issue #57

Changes from all commits

Commits

Show all changes

1 commit

Select commit

007f134

bpo-19675: Fixes pool cleanup issue

dsoprea Feb 12, 2017

File filter

Filter by extension .py (1) All 1 file type selected

Viewed files

Clear filters

Conversations

Failed to load comments.

Uh oh!

There was an error while loading. Please reload this page.

Jump to

Jump to file

Failed to load files.

Uh oh!

There was an error while loading. Please reload this page.

Diff view

Unified

Split

Hide whitespace

Diff view

Unified

Split

Hide whitespace

There are no files selected for viewing

36 changes: 24 additions & 12 deletions 36 Lib/multiprocessing/pool.py

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -220,19 +220,31 @@ def _repopulate_pool(self):
		"""Bring the number of pool processes up to the specified number,
		for use after reaping workers which have exited.
		"""
		for i in range(self._processes - len(self._pool)):
		w = self.Process(target=worker,
		args=(self._inqueue, self._outqueue,
		self._initializer,
		self._initargs, self._maxtasksperchild,
		self._wrap_exception)
		)
		self._pool.append(w)
		w.name = w.name.replace('Process', 'PoolWorker')
		w.daemon = True
		w.start()
		util.debug('added worker')
		try:
		for i in range(self._processes - len(self._pool)):
		w = self.Process(target=worker,
		args=(self._inqueue, self._outqueue,
		self._initializer,
		self._initargs, self._maxtasksperchild)
		)
		self._pool.append(w)
		w.name = w.name.replace('Process', 'PoolWorker')
		w.daemon = True
		w.start()
		util.debug('added worker')
		except:
		util.debug("Process creation error. Cleaning-up (%d) workers." % (len(self._pool)))

		for process in self._pool:
		if process.is_alive() is False:
		continue

		process.terminate()
		process.join()

		util.debug("Processing cleaning-up. Bubbling error.")
		raise

		def _maintain_pool(self):
		"""Clean up any exited workers and start replacements for them.
		"""
Expand Down

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.