GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-32604: Swap threads only if the interpreter is different. by ericsnowcurrently · Pull Request #5778 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Feb 20, 2018 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The CPython runtime assumes that there is a one-to-one relationship (for a given interpreter) between PyThreadState and OS threads. Sending and receiving on a channel in the same interpreter was causing crashes because of this (specifically due to a check in PyThreadState_Swap()). The solution is to not switch threads if the interpreter is the same.

https://bugs.python.org/issue32604

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ericsnowcurrently added 2 commits February 20, 2018 17:14
@ericsnowcurrently
Add tests that ensure we properly handle restoring in same interpreter.
3455570
@ericsnowcurrently
Swap threads only if the interpreter is different.
e1d0383
@ericsnowcurrently ericsnowcurrently added the skip news label Feb 20, 2018
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 20, 2018
@bedevere-bot bedevere-bot added the awaiting merge label Feb 20, 2018
@ericsnowcurrently ericsnowcurrently added needs backport to 3.7 awaiting merge and removed awaiting merge labels Feb 20, 2018
@ericsnowcurrently
ericsnowcurrently merged commit f53d9f2 into python:master Feb 20, 2018
@miss-islington

miss-islington commented Feb 20, 2018

Copy link
Copy Markdown
Contributor

Thanks @ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 20, 2018
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 20, 2018
@ericsnowcurrently @miss-islington
bpo-32604: Swap threads only if the interpreter is different. (python…
2f3f233 
…gh-5778)

The CPython runtime assumes that there is a one-to-one relationship (for a given interpreter) between PyThreadState and OS threads. Sending and receiving on a channel in the same interpreter was causing crashes because of this (specifically due to a check in PyThreadState_Swap()). The solution is to not switch threads if the interpreter is the same.
(cherry picked from commit f53d9f2)

Co-authored-by: Eric Snow <[email protected]>
@bedevere-bot

bedevere-bot commented Feb 20, 2018

Copy link
Copy Markdown

GH-5783 is a backport of this pull request to the 3.7 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.7 label Feb 20, 2018
@ericsnowcurrently
ericsnowcurrently deleted the fix-thread-swap-same-interpreter branch February 20, 2018 23:32
@ericsnowcurrently ericsnowcurrently mentioned this pull request Aug 24, 2018
swap threads only if different interpreter ericsnowcurrently/multi-core-python#7
Closed
@ericsnowcurrently ericsnowcurrently mentioned this pull request Apr 10, 2022
[subinterpreters] PEP 554 implementation: add interpreters module #76785
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@ericsnowcurrently @miss-islington @bedevere-bot @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.