GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Revert "bpo-31961: subprocess now accepts path-like args (GH-4329)" by serhiy-storchaka · Pull Request #5912 · python/cpython

Conversation

serhiy-storchaka commented Feb 26, 2018 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

This reverts commit dd42cb7 ~~and commit 5537646~~.

https://bugs.python.org/issue31961

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Revert "bpo-31961: subprocess now accepts path-like args (pythonGH-4329…

ef212f0

…)"

This reverts commit dd42cb7.

serhiy-storchaka added the needs backport to 3.7 label

Feb 26, 2018

serhiy-storchaka requested a review from gpshead as a code owner

February 26, 2018 20:53

bedevere-bot added the awaiting merge label

Feb 26, 2018

gpshead reviewed

Feb 26, 2018

View reviewed changes

Comment thread

Lib/test/test_subprocess.py Outdated

gpshead Feb 26, 2018

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not revert 5537646. It should be a bugfix no matter what. cmd is a list and comes through the repr into this python code string as a list. using [cmd] would make it a list of lists which is never desirable here.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

gpshead commented Feb 26, 2018

Copy link

Copy Markdown

Member

We do need a Misc/NEWS entry - either adding one saying the previous change was undone, or removing the Misc/NEWS entry that was added for the original change. I've asked Ned on the bug which way we should go with that.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Update the NEWS entry.

d13d0a5

serhiy-storchaka force-pushed the revert-31961 branch from c301c04 to d13d0a5 Compare

February 26, 2018 22:41

ned-deily commented Feb 27, 2018

Copy link

Copy Markdown

Member

Is this ready to go?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka commented Feb 27, 2018

Copy link

Copy Markdown

Member Author

Only if we will decide to revert this feature completely. If we will decide to keep it see the bugfix PR #5914.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ned-deily commented Feb 27, 2018

Copy link

Copy Markdown

Member

I'll give @gpshead a few hours to chime in since it is early in the day for him.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ned-deily added the skip news label

Feb 27, 2018

ned-deily commented Feb 27, 2018

Copy link

Copy Markdown

Member

The clock has run out for 3.7.0b2. I'm going to push this and backport it to 3.7. We can decide later what to do for both 3.8 and 3.7.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ned-deily merged commit be50a7b into python:master

Feb 27, 2018

bedevere-bot commented Feb 27, 2018

Copy link

Copy Markdown

@ned-deily: Please replace # with GH- in the commit message next time. Thanks!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington commented Feb 27, 2018

Copy link

Copy Markdown

Contributor

Thanks @serhiy-storchaka for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the awaiting merge label

Feb 27, 2018

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Feb 27, 2018


          Revert "bpo-31961: subprocess now accepts path-like args (pythonGH-4329…

d6ce482

…)" (pythonGH-5912)

* Revert "bpo-31961: subprocess now accepts path-like args (pythonGH-4329)"

This reverts commit dd42cb7.
(cherry picked from commit be50a7b)

Co-authored-by: Serhiy Storchaka <[email protected]>

ned-deily pushed a commit that referenced this pull request

Feb 27, 2018


          Revert "bpo-31961: subprocess now accepts path-like args (GH-4329)" (G…

b7dcae3

…H-5912) (GH-5931)

* Revert "bpo-31961: subprocess now accepts path-like args (GH-4329)"

This reverts commit dd42cb7.
(cherry picked from commit be50a7b)

Co-authored-by: Serhiy Storchaka <[email protected]>

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request

Feb 28, 2018


          Revert "Revert "bpo-31961: subprocess now accepts path-like args (pyt…

0b4e876

…honGH-4329)" (python#5912)"

This reverts commit be50a7b.

bedevere-bot commented Mar 18, 2018

Copy link

Copy Markdown

GH-5931 is a backport of this pull request to the 3.7 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.7 label

Mar 18, 2018

serhiy-storchaka deleted the revert-31961 branch

October 30, 2018 20:08

Reviewers

gpshead

gpshead left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

serhiy-storchaka commented Feb 26, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gpshead Feb 26, 2018

Choose a reason for hiding this comment

Uh oh!

gpshead commented Feb 26, 2018

Uh oh!

ned-deily commented Feb 27, 2018

Uh oh!

serhiy-storchaka commented Feb 27, 2018

Uh oh!

ned-deily commented Feb 27, 2018

Uh oh!

ned-deily commented Feb 27, 2018

Uh oh!

bedevere-bot commented Feb 27, 2018

Uh oh!

miss-islington commented Feb 27, 2018

Uh oh!

bedevere-bot commented Mar 18, 2018

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

serhiy-storchaka commented Feb 26, 2018 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.