GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-31804: Fix multiprocessing.Process with broken standard streams by pitrou · Pull Request #6079 · python/cpython

Conversation

@pitrou

@pitrou pitrou commented Mar 11, 2018 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

In some conditions the standard streams will be None or closed in the child process (for example if using "pythonw" instead of "python" on Windows). Avoid failing with a non-0 exit code in those conditions.

Report and initial patch by @poxthegreat.

https://bugs.python.org/issue31804

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pitrou
bpo-31804: Fix multiprocessing.Process with broken standard streams
653ed40 
In some conditions the standard streams will be None or closed in the child process
(for example if using "pythonw" instead of "python" on Windows).  Avoid failing
with a non-0 exit code in those conditions.

Report and initial patch by poxthegreat.
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 11, 2018
@bedevere-bot bedevere-bot added the awaiting merge label Mar 11, 2018
@pitrou pitrou mentioned this pull request Mar 11, 2018
bpo-31804: multiprocessing calls flush on sys.stdout at exit even if … #5492
Closed
@pitrou
pitrou merged commit e756f66 into python:master Mar 11, 2018
@bedevere-bot

bedevere-bot commented Mar 11, 2018

Copy link
Copy Markdown

@pitrou: Please replace # with GH- in the commit message next time. Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Mar 11, 2018
@pitrou pitrou added needs backport to 3.6 labels Mar 11, 2018
@miss-islington

miss-islington commented Mar 11, 2018

Copy link
Copy Markdown
Contributor

Thanks @pitrou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Mar 11, 2018

Copy link
Copy Markdown
Contributor

Thanks @pitrou for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Mar 11, 2018

Copy link
Copy Markdown
Contributor

Sorry, @pitrou, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker e756f66c83786ee82f5f7d45931ae50a6931dd7f 3.6
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Mar 11, 2018

Copy link
Copy Markdown
Contributor

Sorry, @pitrou, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker e756f66c83786ee82f5f7d45931ae50a6931dd7f 2.7
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pitrou pitrou added the needs backport to 3.7 label Mar 11, 2018
@miss-islington

miss-islington commented Mar 11, 2018

Copy link
Copy Markdown
Contributor

Thanks @pitrou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pitrou
pitrou deleted the bpo-31804-mp-std-streams branch March 11, 2018 18:24
@bedevere-bot

bedevere-bot commented Mar 11, 2018

Copy link
Copy Markdown

GH-6080 is a backport of this pull request to the 3.7 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.7 label Mar 11, 2018
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 11, 2018
@pitrou @miss-islington
bpo-31804: Fix multiprocessing.Process with broken standard streams (p…
42d0b80 
…ythonGH-6079)

In some conditions the standard streams will be None or closed in the child process (for example if using "pythonw" instead of "python" on Windows).  Avoid failing with a non-0 exit code in those conditions.

Report and initial patch by poxthegreat.
(cherry picked from commit e756f66)

Co-authored-by: Antoine Pitrou <[email protected]>
pitrou added a commit to pitrou/cpython that referenced this pull request Mar 11, 2018
@pitrou
[3.6] bpo-31804: Fix multiprocessing.Process with broken standard str…
feab7c4 
…eams (pythonGH-6079)

In some conditions the standard streams will be None or closed in the child process (for example if using "pythonw" instead of "python" on Windows).  Avoid failing with a non-0 exit code in those conditions.

Report and initial patch by poxthegreat..
(cherry picked from commit e756f66)
@bedevere-bot

bedevere-bot commented Mar 11, 2018

Copy link
Copy Markdown

GH-6081 is a backport of this pull request to the 3.6 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.6 label Mar 11, 2018
@pitrou pitrou removed the needs backport to 2.7 label Mar 11, 2018
pitrou added a commit that referenced this pull request Mar 11, 2018
@miss-islington @pitrou
bpo-31804: Fix multiprocessing.Process with broken standard streams (G…
ff5d213 
…H-6079) (GH-6080)

In some conditions the standard streams will be None or closed in the child process (for example if using "pythonw" instead of "python" on Windows).  Avoid failing with a non-0 exit code in those conditions.

Report and initial patch by poxthegreat.
(cherry picked from commit e756f66)

Co-authored-by: Antoine Pitrou <[email protected]>
pitrou added a commit that referenced this pull request Mar 11, 2018
@pitrou
[3.6] bpo-31804: Fix multiprocessing.Process with broken standard str…
069b8d2 
…eams (GH-6079) (GH-6081)

In some conditions the standard streams will be None or closed in the child process (for example if using "pythonw" instead of "python" on Windows).  Avoid failing with a non-0 exit code in those conditions.

Report and initial patch by poxthegreat..
(cherry picked from commit e756f66)
jo2y pushed a commit to jo2y/cpython that referenced this pull request Mar 23, 2018
@pitrou @jo2y
bpo-31804: Fix multiprocessing.Process with broken standard streams (p…
b4c984f 
…ython#6079)

In some conditions the standard streams will be None or closed in the child process (for example if using "pythonw" instead of "python" on Windows).  Avoid failing with a non-0 exit code in those conditions.

Report and initial patch by poxthegreat.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@pitrou @bedevere-bot @miss-islington @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.