GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — bpo-29481: DOC: mark which version typing.Deque added by tacaswell · Pull Request #61 · python/cpython

Conversation

tacaswell commented Feb 13, 2017

Copy link

Copy Markdown

Contributor

This is targeted at 3.6, but half of it should be backported to 3.5.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

the-knights-who-say-ni added the CLA not signed label

Feb 13, 2017

the-knights-who-say-ni commented Feb 13, 2017

Copy link

Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA. This is necessary for legal reasons before we can look at your contribution. Please follow these steps to help rectify the issue:

If you don't have an account on b.p.o, please create one
Make sure your GitHub username is listed in "Your Details" at b.p.o
If you have not already done so, please sign the PSF contributor agreement
If you just signed the CLA, please wait at least a day and then check "Your Details" on bugs.python.org to see if your account has been marked as having signed the CLA (the delay is due to a person having to manually check your signed CLA)
Reply here saying you have completed the above steps

Thanks again to your contribution and we look forward to looking at it!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

tacaswell changed the base branch from master to 3.6

February 13, 2017 04:01

codecov Bot commented Feb 13, 2017 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Codecov Report

Merging #61 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
+ Coverage   82.37%   82.37%   +<.01%     
==========================================
  Files        1427     1427              
  Lines      350948   350948              
==========================================
+ Hits       289091   289095       +4     
+ Misses      61857    61853       -4

Impacted Files	Coverage Δ
Lib/heapq.py	`96.56% <ø> (-0.77%)`	❌
Lib/threading.py	`82.6% <ø> (-0.18%)`	❌
Lib/test/test_smtplib.py	`86.71% <ø> (+0.22%)`	✅
Lib/test/test_strptime.py	`95.01% <ø> (+0.26%)`	✅
Lib/_strptime.py	`95.01% <ø> (+0.33%)`	✅
Lib/test/test_thread.py	`66.83% <ø> (+0.51%)`	✅
Lib/test/test_capi.py	`92.5% <ø> (+0.55%)`	✅

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 649a7ca...5dd1ab0. Read the comment docs.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

berkerpeksag requested changes

Feb 13, 2017

View reviewed changes

berkerpeksag left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've re-targeted this to master branch. We can then backport this to 3.6. For 3.5, we'll need a separate PR that adds .. versionadded:: 3.5.4.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Doc/library/typing.rst Outdated

berkerpeksag Feb 13, 2017

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For 3.6 docs, we can remove .. versionadded:: 3.5.4.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

berkerpeksag changed the base branch from 3.6 to master

February 13, 2017 11:26

tacaswell commented Feb 13, 2017

Copy link

Copy Markdown

Contributor Author

Should the 3.5 one also target master?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          DOC: mark which version typing.Deque added

5dd1ab0

tacaswell force-pushed the doc_deque_vadded branch from 86b0fa5 to 5dd1ab0 Compare

February 13, 2017 13:23

tacaswell commented Feb 13, 2017

Copy link

Copy Markdown

Contributor Author

fixed and force-pushed.

I am currently running the CLA by my employer, it may be faster to just have someone else do this (given how minor it is).

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

berkerpeksag commented Feb 13, 2017

Copy link

Copy Markdown

Member

Should the 3.5 one also target master?

3.5 should be against 3.5 branch, but don't worry about that :) Core developers can do the 3.5 backport.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

tacaswell commented Feb 15, 2017

Copy link

Copy Markdown

Contributor Author

Closing as this can be fixed faster by others than I expect to be able to sign the CLA.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

tacaswell closed this

Feb 15, 2017

tacaswell deleted the doc_deque_vadded branch

February 15, 2017 13:32

gvanrossum mentioned this pull request

Apr 10, 2022

Test issue #47020

Closed

jaraco pushed a commit that referenced this pull request

Dec 2, 2022


          Add more unittests (GH-61)

acf5c06

jaraco pushed a commit to jaraco/cpython that referenced this pull request

Feb 17, 2023


          Backport fix for test isolation from Python 3.8/3.7. Closes python#61

a4f0d6e

jaraco pushed a commit to jaraco/cpython that referenced this pull request

Feb 17, 2023


          Merge branch 'issue61' into 'master'

14d8cd8

Backport fix for test isolation from Python 3.8/3.7

Closes python#61

See merge request python-devs/importlib_resources!63

jaraco pushed a commit to jaraco/cpython that referenced this pull request

Feb 17, 2023


          Update base URL for PEPs (python#61)

a4f5b76

isidentical pushed a commit to isidentical/cpython that referenced this pull request

Mar 30, 2023


          Merge pull request python#61 from isidentical/solve-conversion-handle

59ec33d

gvanrossum mentioned this pull request

Aug 22, 2023

heap-use-after-free in _PyFunction_LookupByVersion #108253

Closed

LinanV mentioned this pull request

Oct 23, 2023

Objects/typeobject.c: No such file or directory. #111203

Closed

ngoldbaum mentioned this pull request

Sep 23, 2024

Crash running PyO3 tests with --test-threads=1000 #124375

Closed

This was referenced Feb 11, 2025

segmentfault when pip installing setuptools #129992

Closed

segmentfault when pip installing setuptools #129993

Closed

AA-Turner pushed a commit to AA-Turner/cpython that referenced this pull request

Apr 10, 2025


          Fix for segv in _PyInterpolation_FromStackRefSteal (python#61)

e6d01ef

sergey-miryanov mentioned this pull request

Dec 18, 2025

Observed memory leak in ssl library: Python 3.14 GC issue #142516

Closed

ngoldbaum mentioned this pull request

Mar 6, 2026

Remove deprecated and undocumented function ctypes.SetPointerType #133866

Closed

Reviewers

berkerpeksag

berkerpeksag requested changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

tacaswell commented Feb 13, 2017

Uh oh!

the-knights-who-say-ni commented Feb 13, 2017

Uh oh!

codecov Bot commented Feb 13, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

berkerpeksag left a comment

Choose a reason for hiding this comment

Uh oh!

berkerpeksag Feb 13, 2017

Choose a reason for hiding this comment

Uh oh!

tacaswell commented Feb 13, 2017

Uh oh!

tacaswell commented Feb 13, 2017

Uh oh!

berkerpeksag commented Feb 13, 2017

Uh oh!

tacaswell commented Feb 15, 2017

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov Bot commented Feb 13, 2017 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.