GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Use h3 headings for build sections in README by eklitzke · Pull Request #64 · python/cpython

Conversation

eklitzke commented Feb 13, 2017

Copy link

Copy Markdown

Contributor

I think the sections about different compiler options should be sub-sections of the "Building" section. This change does that -- the LTO and profile-guided optimization sections are now "h3" sections.

You can see how this renders on GitHub at https://github.com/eklitzke/cpython/tree/docs

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

the-knights-who-say-ni commented Feb 13, 2017

Copy link

Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA. This is necessary for legal reasons before we can look at your contribution. Please follow these steps to help rectify the issue:

If you don't have an account on b.p.o, please create one
Make sure your GitHub username is listed in "Your Details" at b.p.o
If you have not already done so, please sign the PSF contributor agreement
If you just signed the CLA, please wait at least a day and then check "Your Details" on bugs.python.org to see if your account has been marked as having signed the CLA (the delay is due to a person having to manually check your signed CLA)
Reply here saying you have completed the above steps

Thanks again to your contribution and we look forward to looking at it!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

the-knights-who-say-ni added the CLA not signed label

Feb 13, 2017

methane reviewed

Feb 13, 2017

View reviewed changes

methane left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for suggestion.
How about adding TOC before "Build Instructions"?

.. contents::

(ref github/markup#391)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

README.rst Outdated

methane Feb 13, 2017

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use ^^^^^^^ as subsubsection header.
https://docs.python.org/devguide/documenting.html#sections

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Use h3 headings for build sections, and add TOC

bcfc22c

eklitzke force-pushed the docs branch from 57d3c92 to bcfc22c Compare

February 13, 2017 09:11

eklitzke commented Feb 13, 2017

Copy link

Copy Markdown

Contributor Author

Add TOC, and used ^^^^ for delimiting the subsections.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

methane approved these changes

Feb 13, 2017

View reviewed changes

methane left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Please sign CLA and wait it applied.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

codecov Bot commented Feb 13, 2017

Copy link

Copy Markdown

Codecov Report

Merging #64 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #64   +/-   ##
=======================================
  Coverage   82.37%   82.37%           
=======================================
  Files        1427     1427           
  Lines      350948   350948           
=======================================
  Hits       289091   289091           
  Misses      61857    61857

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 649a7ca...bcfc22c. Read the comment docs.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

methane removed the CLA not signed label

Feb 20, 2017

the-knights-who-say-ni added the CLA not signed label

Feb 20, 2017

methane commented Feb 20, 2017

Copy link

Copy Markdown

Member

@eklitzke Could you sign the CLA?
step is described by #64 (comment)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

methane removed the CLA not signed label

Feb 28, 2017

the-knights-who-say-ni added the CLA not signed label

Feb 28, 2017

methane merged commit 6db764a into python:master

Feb 28, 2017

jaraco pushed a commit to jaraco/cpython that referenced this pull request

Feb 17, 2023


          Add an important note about Python < 3.7

6f880d6

Closes python#64

jaraco pushed a commit to jaraco/cpython that referenced this pull request

Feb 17, 2023


          Merge branch 'issue64' into 'master'

e6e4e46

Add an important note about Python < 3.7

Closes python#64

See merge request python-devs/importlib_resources!65

lysnikolaou referenced this pull request in lysnikolaou/cpython

Apr 7, 2023


          Merge pull request #64 from lysnikolaou/preserve-double-brance-format…

aba4fc9

…spec

gvanrossum mentioned this pull request

Aug 22, 2023

heap-use-after-free in _PyFunction_LookupByVersion #108253

Closed

LinanV mentioned this pull request

Oct 23, 2023

Objects/typeobject.c: No such file or directory. #111203

Closed

ngoldbaum mentioned this pull request

Sep 23, 2024

Crash running PyO3 tests with --test-threads=1000 #124375

Closed

This was referenced Feb 11, 2025

segmentfault when pip installing setuptools #129992

Closed

segmentfault when pip installing setuptools #129993

Closed

AA-Turner added a commit to AA-Turner/cpython that referenced this pull request

Apr 17, 2025


          Fix Windows build (python#64)

d6c470c

sergey-miryanov mentioned this pull request

Dec 18, 2025

Observed memory leak in ssl library: Python 3.14 GC issue #142516

Closed

ngoldbaum mentioned this pull request

Mar 6, 2026

Remove deprecated and undocumented function ctypes.SetPointerType #133866

Closed

Reviewers

methane

methane approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.