GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-31201: Clarify command to re-run failing test(s) with example by aaronang · Pull Request #6417 · python/cpython

Conversation

@aaronang

@aaronang aaronang commented Apr 8, 2018 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue31201

https://bugs.python.org/issue31201

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@aaronang
bpo-31201: Clarify command to re-run failing test(s) with example
682847e
@the-knights-who-say-ni the-knights-who-say-ni added the CLA not signed label Apr 8, 2018
@the-knights-who-say-ni

the-knights-who-say-ni commented Apr 8, 2018

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting review label Apr 8, 2018
ned-deily
ned-deily requested changes Apr 8, 2018
View reviewed changes
Comment thread README.rst Outdated
example, if ``test_os`` and ``test_gdb`` failed, you can run::

make test TESTOPTS="-v test_that_failed"
make test TESTOPTS="-v test_os test_gdb"

@ned-deily ned-deily Apr 8, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the (additional) preceding space?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@aaronang aaronang Apr 9, 2018

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, nice catch.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot

bedevere-bot commented Apr 8, 2018

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting changes and removed awaiting review labels Apr 8, 2018
@ned-deily ned-deily added the skip news label Apr 8, 2018
@aaronang
Remove redundant space
bcbe3e6
@the-knights-who-say-ni the-knights-who-say-ni added CLA signed and removed CLA not signed labels Apr 9, 2018
@aaronang

aaronang commented Apr 9, 2018

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Apr 9, 2018

Copy link
Copy Markdown

Thanks for making the requested changes!

@ned-deily: please review the changes made to this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting change review and removed awaiting changes labels Apr 9, 2018
ned-deily
ned-deily approved these changes Apr 9, 2018
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting change review labels Apr 9, 2018
@ned-deily ned-deily added needs backport to 3.6 labels Apr 9, 2018
@ned-deily
ned-deily merged commit 0f914b5 into python:master Apr 9, 2018
@miss-islington

miss-islington commented Apr 9, 2018

Copy link
Copy Markdown
Contributor

Thanks @aaronang for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Apr 9, 2018
@bedevere-bot

bedevere-bot commented Apr 9, 2018

Copy link
Copy Markdown

GH-6437 is a backport of this pull request to the 3.7 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.7 label Apr 9, 2018
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 9, 2018
@aaronang @miss-islington
bpo-31201: Clarify command to re-run failing test(s) with example (py…
563143e 
…thonGH-6417)

(cherry picked from commit 0f914b5)

Co-authored-by: Aaron Ang <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 9, 2018
@aaronang @miss-islington
bpo-31201: Clarify command to re-run failing test(s) with example (py…
fa06845 
…thonGH-6417)

(cherry picked from commit 0f914b5)

Co-authored-by: Aaron Ang <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.6 label Apr 9, 2018
@bedevere-bot

bedevere-bot commented Apr 9, 2018

Copy link
Copy Markdown

GH-6438 is a backport of this pull request to the 3.6 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ned-deily pushed a commit that referenced this pull request Apr 9, 2018
@miss-islington @aaronang @ned-deily
[3.7] bpo-31201: Clarify command to re-run failing test(s) with examp…
71a3837 
…le (GH-6417) (GH-6437)

(cherry picked from commit 0f914b5)

Co-authored-by: Aaron Ang <[email protected]>
ned-deily pushed a commit that referenced this pull request Apr 9, 2018
@miss-islington @aaronang @ned-deily
[3.6] bpo-31201: Clarify command to re-run failing test(s) with examp…
83bb399 
…le (GH-6417) (GH-6438)

(cherry picked from commit 0f914b5)

Co-authored-by: Aaron Ang <[email protected]>
@aaronang
aaronang deleted the bpo-31201 branch April 10, 2018 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ned-deily ned-deily ned-deily approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@aaronang @the-knights-who-say-ni @bedevere-bot @miss-islington @ned-deily
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.