GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-5945: Improve mappings and sequences C API docs. by serhiy-storchaka · Pull Request #7029 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented May 21, 2018 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This fixes bpo-5945, but may also have relations to other open documentation issues.

https://bugs.python.org/issue5945

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
bpo-5945: Improve mappings and sequences C API docs.
f5f8f01
@serhiy-storchaka serhiy-storchaka added needs backport to 3.6 docs Documentation in the Doc dir skip news labels May 21, 2018
@serhiy-storchaka
serhiy-storchaka requested review from vadmium and vstinner May 21, 2018 10:52
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label May 21, 2018
@bedevere-bot bedevere-bot added the awaiting merge label May 21, 2018
willingc
willingc approved these changes May 21, 2018
View reviewed changes

@willingc willingc left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @serhiy-storchaka for these clear and helpful doc changes

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
serhiy-storchaka merged commit f5b1183 into python:master May 22, 2018
@miss-islington

miss-islington commented May 22, 2018

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label May 22, 2018
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 22, 2018
@serhiy-storchaka @miss-islington
bpo-5945: Improve mappings and sequences C API docs. (pythonGH-7029)
6379a97 
(cherry picked from commit f5b1183)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-bot

bedevere-bot commented May 22, 2018

Copy link
Copy Markdown

GH-7045 is a backport of this pull request to the 3.7 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.7 label May 22, 2018
@serhiy-storchaka

serhiy-storchaka commented May 22, 2018

Copy link
Copy Markdown
Member Author

Thanks @willingc for your review.
willingc reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka
serhiy-storchaka deleted the map-seq-c-api-docs branch May 22, 2018 08:03
@miss-islington

miss-islington commented May 22, 2018

Copy link
Copy Markdown
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker f5b1183610d5888db3bbd639b1a0c945dbd8f8dd 3.6
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned serhiy-storchaka May 22, 2018
miss-islington added a commit that referenced this pull request May 22, 2018
@miss-islington @serhiy-storchaka
bpo-5945: Improve mappings and sequences C API docs. (GH-7029)
e1a78ca 
(cherry picked from commit f5b1183)

Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request May 22, 2018
@serhiy-storchaka
[3.6] bpo-5945: Improve mappings and sequences C API docs. (pythonGH-…
7665cf5 
…7029).

(cherry picked from commit f5b1183)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-bot

bedevere-bot commented May 22, 2018

Copy link
Copy Markdown

GH-7049 is a backport of this pull request to the 3.6 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.6 label May 22, 2018
serhiy-storchaka added a commit that referenced this pull request May 22, 2018
@serhiy-storchaka
[3.6] bpo-5945: Improve mappings and sequences C API docs. (GH-7029). (…
93e9fb5 
…GH-7049)

(cherry picked from commit f5b1183)
@ilevkivskyi ilevkivskyi mentioned this pull request Jun 4, 2018
bpo-5945: mapping.rst: PyMapping_Check(list) returns 1 #144
Closed
@serhiy-storchaka serhiy-storchaka removed their assignment Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@willingc willingc willingc approved these changes
@vstinner vstinner Awaiting requested review from vstinner
@vadmium vadmium Awaiting requested review from vadmium

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@serhiy-storchaka @miss-islington @bedevere-bot @willingc @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.