GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Tweak .codedoc.yml to make it more useful by berkerpeksag · Pull Request #71 · python/cpython

Conversation

@berkerpeksag

@berkerpeksag berkerpeksag commented Feb 13, 2017

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 13, 2017
berkerpeksag added 2 commits February 13, 2017 18:37
@berkerpeksag
Tweak .codedoc.yml to make it more useful
8590bb6
@berkerpeksag
Merge branch 'master' into tweak-codecov
2efc23e
briancurtin
briancurtin reviewed Feb 13, 2017
View reviewed changes
Comment thread .codecov.yml Outdated
default:
threshold: 0.01
only_pulls: true
paths:

@briancurtin briancurtin Feb 13, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing this means it only ends up being run for those directories, right? If so, that's good that it avoids being run on, e.g., Doc/* changes, but shouldn't it also run on directories like Objects/?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@berkerpeksag berkerpeksag Feb 13, 2017

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing this means it only ends up being run for those directories, right?

Correct.

[...] but shouldn't it also run on directories like Objects/?

Good point. I'm reading docs again so I hopefully will have an answer :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@berkerpeksag berkerpeksag Feb 13, 2017

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to https://docs.codecov.io/docs/commit-status#section-patch-status, we don't need to add specific directories. It should only look for the changes in PR.

We can also add directories to ignore: https://docs.codecov.io/docs/ignoring-paths

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
berkerpeksag added 5 commits February 13, 2017 18:41
@berkerpeksag
Turn off comments
c602eff
@berkerpeksag
Fix config
6300e70
@berkerpeksag
Disable project level cverage
ed506fa
@berkerpeksag
Fix config file
a4f2f01
@berkerpeksag
More cleanup
8f4f8df
briancurtin
briancurtin reviewed Feb 13, 2017
View reviewed changes

@briancurtin briancurtin left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems ok from what I understand of the docs (particularly the coverage/status/{changes|project} part), but I'd prefer to leave it to another set of eyes to approve.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
brettcannon
brettcannon approved these changes Feb 13, 2017
View reviewed changes
Comment thread .codecov.yml
- "Mac/**/*"
- "PC/**/*"
- "PCbuild/**/*"
- "Tools/**/*"

@brettcannon brettcannon Feb 13, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should add the Grammar directory.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@berkerpeksag berkerpeksag Feb 13, 2017

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, done.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@brettcannon

brettcannon commented Feb 13, 2017

Copy link
Copy Markdown
Member

LGTM. If you can pass it through Codecov's verification tool at https://docs.codecov.io/docs/codecov-yaml#section-validate-your-repository-yaml that would be great.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@berkerpeksag

berkerpeksag commented Feb 13, 2017

Copy link
Copy Markdown
Member Author

Thanks for the review!

If you can pass it through Codecov's verification tool at https://docs.codecov.io/docs/codecov-yaml#section-validate-your-repository-yaml that would be great.

$ curl -XPOST --data-binary @.codecov.yml https://codecov.io/validate
Valid!

# Pretty-printed version of the configuration below
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@berkerpeksag
Add Grammar/*
57955fc
@brettcannon

brettcannon commented Feb 13, 2017

Copy link
Copy Markdown
Member

Then I say merge it and let python-dev (or -committers; wherever @Haypo emailed) know about the requisite change.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@berkerpeksag
berkerpeksag merged commit 22ba52b into python:master Feb 14, 2017
@berkerpeksag
berkerpeksag deleted the tweak-codecov branch February 14, 2017 09:56
@berkerpeksag berkerpeksag added backport to 3.5 labels Feb 14, 2017
@Mariatta Mariatta removed needs backport to 3.5 labels Mar 7, 2017
jaraco pushed a commit that referenced this pull request Dec 2, 2022
@pyup-bot @Mariatta
Update pytest from 3.4.1 to 3.4.2 (GH-71)
569c6ff
@gvanrossum gvanrossum mentioned this pull request Aug 22, 2023
heap-use-after-free in _PyFunction_LookupByVersion #108253
Closed
lysnikolaou referenced this pull request in lysnikolaou/cpython Apr 29, 2024
@pablogsal
Merge pull request #71 from mgmacias95/pyrepl
fa37b07 
Test pasting with/without paste mode
@ngoldbaum ngoldbaum mentioned this pull request Sep 23, 2024
Crash running PyO3 tests with --test-threads=1000 #124375
Closed
This was referenced Feb 11, 2025
segmentfault when pip installing setuptools #129992
Closed
segmentfault when pip installing setuptools #129993
Closed
AA-Turner added a commit to AA-Turner/cpython that referenced this pull request Apr 19, 2025
@AA-Turner
Add more concatenation tests (python#71)
4c6cb47
@1nftf 1nftf mentioned this pull request Nov 30, 2025
Improve printf-style formatting docs for non-built-in types #142108
Open
@sergey-miryanov sergey-miryanov mentioned this pull request Dec 18, 2025
Observed memory leak in ssl library: Python 3.14 GC issue #142516
Closed
@ngoldbaum ngoldbaum mentioned this pull request Mar 6, 2026
Remove deprecated and undocumented function ctypes.SetPointerType #133866
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@briancurtin briancurtin briancurtin left review comments
@brettcannon brettcannon brettcannon approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@berkerpeksag @brettcannon @briancurtin @Mariatta @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.