GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-32458: Increase TLS timeout in test_asyncio by vstinner · Pull Request #7157 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented May 28, 2018 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

test_asyncio: Increase test_start_tls_server_1() client timeout from
5 seconds to 60 seconds, and server timeout from 10 to 120 seconds.

The timeout is only used to check if the test hangs, but the 5
seconds limit is commonly reached on slow CIs like Travis CI and some
buildbots.

https://bugs.python.org/issue32458

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
bpo-32458: Increase TLS timeout in test_asyncio
8aa07d5 
test_asyncio: Increase test_start_tls_server_1() client timeout from
5 seconds to 60 seconds, and server timeout from 10 to 120 seconds.

The timeout is only used to check if the test hangs, but the 5
seconds limit is commonly reached on slow CIs like Travis CI and some
buildbots.
@vstinner
vstinner requested a review from 1st1 May 28, 2018 15:47
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label May 28, 2018
@bedevere-bot bedevere-bot added the awaiting merge label May 28, 2018
@vstinner vstinner added skip news needs backport to 3.7 labels May 28, 2018
@vstinner

vstinner commented May 28, 2018

Copy link
Copy Markdown
Member Author

I tested manually my PR on my laptop and I failed to make the test fail again. I opened 4 terminals to run commands in parallel:

(1) ./python -m test test_asyncio -m test_start_tls_server_1 -F
(2) ./python -m test -j16 -r
(3) ./python -m test -j16 -r
(4) ./python -m test -j16 -r

The system load was larger than 42.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
Reenable ProactorStartTLSTests
895ed6b
@vstinner

vstinner commented May 28, 2018

Copy link
Copy Markdown
Member Author

Oh, the PR #5054 disabled SSL tests on the proactor event loop: my PR now also reenables these tests. Let's see if test_asyncio of my PR pass on AppVeyor ;-)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@1st1

1st1 commented May 28, 2018

Copy link
Copy Markdown
Member

Sorry, need to close this as it's in direct conflict with #7130 that I'm about to merge :(
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@1st1 1st1 closed this May 28, 2018
@vstinner
vstinner deleted the asyncio_tls branch May 29, 2018 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 Awaiting requested review from 1st1

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting merge skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@vstinner @1st1 @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.