GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — bpo-33654: Support BufferedProtocol in set_protocol() and start_tls() by 1st1 · Pull Request #7130 · python/cpython

Conversation

1st1 commented May 26, 2018 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

https://bugs.python.org/issue33654

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

1st1 added the needs backport to 3.7 label

May 26, 2018

1st1 self-assigned this

May 26, 2018

1st1 requested a review from asvetlov

May 26, 2018 17:10

the-knights-who-say-ni added the CLA signed label

May 26, 2018

bedevere-bot added the awaiting merge label

May 26, 2018

1st1 force-pushed the fixbuf branch from 0ff4121 to 121bc9c Compare

May 26, 2018 17:54


          bpo-33654: Support BufferedProtocol in set_protocol() and start_tls()

bd43e1d

1st1 force-pushed the fixbuf branch from 121bc9c to bd43e1d Compare

May 26, 2018 17:56


          Fix code-style to trigger VSCE buildbots

358b7b6

asvetlov approved these changes

May 26, 2018

View reviewed changes

asvetlov left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

asvetlov commented May 26, 2018

Copy link

Copy Markdown

Contributor

hmm, windows tests are failing

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

1st1 commented May 26, 2018

Copy link

Copy Markdown

Member Author

Yes, i'll be looking into win issues before merging.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Fix proactor bugs

0238da4

1st1 commented May 27, 2018

Copy link

Copy Markdown

Member Author

@asvetlov please take a look at the 0238da4 -- I think I fixed the windows issue

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Update tests to be compatible with OpenSSL 1.1.1

bd17a55

asvetlov commented May 28, 2018

Copy link

Copy Markdown

Contributor

Wow, nice.
Waiting for merge.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Yury Selivanov added 3 commits

May 28, 2018 11:06


          Fix comment

fe3cd21


          Tweak defaults in TLS tests

7b7c7a2


          Clarify docs

d749582

1st1 mentioned this pull request

May 28, 2018

bpo-32458: Increase TLS timeout in test_asyncio #7157

Closed

Yury Selivanov added 2 commits

May 28, 2018 12:18


          Bump TLS tests timeouts to 60 seconds; eliminate possible race from s…

e58adad

…tart_serving


          Rewrite test_start_tls_server_1

bcbae28

1st1 merged commit dbf1022 into python:master

May 28, 2018

miss-islington commented May 28, 2018

Copy link

Copy Markdown

Contributor

Thanks @1st1 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the awaiting merge label

May 28, 2018

1st1 deleted the fixbuf branch

May 28, 2018 18:31

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

May 28, 2018


          bpo-33654: Support BufferedProtocol in set_protocol() and start_tls() (…

541b923

…pythonGH-7130)

In this commit:

* Support BufferedProtocol in set_protocol() and start_tls()
* Fix proactor to cancel readers reliably
* Update tests to be compatible with OpenSSL 1.1.1
* Clarify BufferedProtocol docs
* Bump TLS tests timeouts to 60 seconds; eliminate possible race from start_serving
* Rewrite test_start_tls_server_1
(cherry picked from commit dbf1022)

Co-authored-by: Yury Selivanov <[email protected]>

bedevere-bot commented May 28, 2018

Copy link

Copy Markdown

GH-7164 is a backport of this pull request to the 3.7 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.7 label

May 28, 2018

miss-islington added a commit that referenced this pull request

May 28, 2018


          bpo-33654: Support BufferedProtocol in set_protocol() and start_tls() (…

bc3a002

…GH-7130)

In this commit:

* Support BufferedProtocol in set_protocol() and start_tls()
* Fix proactor to cancel readers reliably
* Update tests to be compatible with OpenSSL 1.1.1
* Clarify BufferedProtocol docs
* Bump TLS tests timeouts to 60 seconds; eliminate possible race from start_serving
* Rewrite test_start_tls_server_1
(cherry picked from commit dbf1022)

Co-authored-by: Yury Selivanov <[email protected]>

Reviewers

asvetlov

asvetlov approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

1st1

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

1st1 commented May 26, 2018 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

asvetlov left a comment

Choose a reason for hiding this comment

Uh oh!

asvetlov commented May 26, 2018

Uh oh!

1st1 commented May 26, 2018

Uh oh!

1st1 commented May 27, 2018

Uh oh!

asvetlov commented May 28, 2018

Uh oh!

miss-islington commented May 28, 2018

Uh oh!

bedevere-bot commented May 28, 2018

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

1st1 commented May 26, 2018 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.