GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.7] bpo-33654: Support BufferedProtocol in set_protocol() and start_tls() (GH-7130) by miss-islington · Pull Request #7164 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented May 28, 2018 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

In this commit:

  • Support BufferedProtocol in set_protocol() and start_tls()
  • Fix proactor to cancel readers reliably
  • Update tests to be compatible with OpenSSL 1.1.1
  • Clarify BufferedProtocol docs
  • Bump TLS tests timeouts to 60 seconds; eliminate possible race from start_serving
  • Rewrite test_start_tls_server_1
    (cherry picked from commit dbf1022)

Co-authored-by: Yury Selivanov [email protected]

https://bugs.python.org/issue33654

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Yury Selivanov @miss-islington
bpo-33654: Support BufferedProtocol in set_protocol() and start_tls() (…
541b923
…pythonGH-7130)

In this commit:

* Support BufferedProtocol in set_protocol() and start_tls()
* Fix proactor to cancel readers reliably
* Update tests to be compatible with OpenSSL 1.1.1
* Clarify BufferedProtocol docs
* Bump TLS tests timeouts to 60 seconds; eliminate possible race from start_serving
* Rewrite test_start_tls_server_1
(cherry picked from commit dbf1022)

Co-authored-by: Yury Selivanov <[email protected]>
@miss-islington
miss-islington requested review from 1st1 and asvetlov as code owners May 28, 2018 18:32
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label May 28, 2018
@bedevere-bot bedevere-bot mentioned this pull request May 28, 2018
bpo-33654: Support BufferedProtocol in set_protocol() and start_tls() #7130
Merged
@bedevere-bot bedevere-bot added the awaiting review label May 28, 2018
1st1
1st1 approved these changes May 28, 2018
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels May 28, 2018
@miss-islington

miss-islington commented May 28, 2018

Copy link
Copy Markdown
Contributor Author

@1st1: Backport status check is done, and it's a success ✅ .

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington
miss-islington merged commit bc3a002 into python:3.7 May 28, 2018
@miss-islington

miss-islington commented May 28, 2018

Copy link
Copy Markdown
Contributor Author

Thanks!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the awaiting merge label May 28, 2018
@miss-islington
miss-islington deleted the backport-dbf1022-3.7 branch May 28, 2018 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 1st1 approved these changes
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @1st1 @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.