GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-28240: timeit: Update repeat() doc by vstinner · Pull Request #7419 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Jun 5, 2018 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Document that the default value of repeat changed from 3 to 5 in
Python 3.7.

https://bugs.python.org/issue28240

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
bpo-28240: timeit: Update repeat() doc
67ca3c1 
Document that the default value of repeat changed from 3 to 5 in
Python 3.7.
@vstinner vstinner added the skip news label Jun 5, 2018
@vstinner
vstinner requested a review from serhiy-storchaka June 5, 2018 10:43
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 5, 2018
@bedevere-bot bedevere-bot added the awaiting merge label Jun 5, 2018
@vstinner

vstinner commented Jun 5, 2018

Copy link
Copy Markdown
Member Author

@serhiy-storchaka: Is it what you expected in your https://bugs.python.org/issue33771 request? (Would you mind to review this PR please?)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka
serhiy-storchaka requested changes Jun 5, 2018
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update also the CLI docs and docstrings.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 5, 2018
@bedevere-bot

bedevere-bot commented Jun 5, 2018

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

And if you don't make the requested changes, you will be put in the comfy chair!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting changes label Jun 5, 2018
@vstinner
Update also docstrings: default 3 => default 5
a412124
@vstinner

vstinner commented Jun 6, 2018

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting change review and removed awaiting changes labels Jun 6, 2018
@bedevere-bot

bedevere-bot commented Jun 6, 2018

Copy link
Copy Markdown

Thanks for making the requested changes!

@serhiy-storchaka: please review the changes made to this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka
serhiy-storchaka reviewed Jun 6, 2018
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And the CLI documentation please.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
Update CLI documentation
8892dbe
@vstinner

vstinner commented Jun 6, 2018

Copy link
Copy Markdown
Member Author

And the CLI documentation please.

I updated timeit --help, but I missed that the CLI was also documented in Doc/library/timeit.rst. All documentation should now be up to date!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka
serhiy-storchaka approved these changes Jun 6, 2018
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting change review labels Jun 6, 2018
@vstinner
vstinner merged commit 3ef769f into python:master Jun 6, 2018
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 6, 2018
@vstinner
vstinner deleted the timeit_repeat branch June 6, 2018 15:55
@vstinner vstinner added the needs backport to 3.7 label Jun 6, 2018
@miss-islington

miss-islington commented Jun 6, 2018

Copy link
Copy Markdown
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 6, 2018
@vstinner @miss-islington
bpo-28240: timeit: Update repeat() doc (pythonGH-7419)
14c9103 
Document that the default value of repeat changed from 3 to 5 in
Python 3.7.
(cherry picked from commit 3ef769f)

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-bot

bedevere-bot commented Jun 6, 2018

Copy link
Copy Markdown

GH-7457 is a backport of this pull request to the 3.7 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.7 label Jun 6, 2018
vstinner added a commit that referenced this pull request Jun 6, 2018
@miss-islington @vstinner
bpo-28240: timeit: Update repeat() doc (GH-7419) (GH-7457)
cebd4b0 
Document that the default value of repeat changed from 3 to 5 in
Python 3.7.
(cherry picked from commit 3ef769f)

Co-authored-by: Victor Stinner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@vstinner @bedevere-bot @miss-islington @serhiy-storchaka @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.