GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-33663: Convert content length to string before putting to header by ValeriyaSinevich · Pull Request #7754 · python/cpython

Conversation

@ValeriyaSinevich

@ValeriyaSinevich ValeriyaSinevich commented Jun 16, 2018 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue33663

https://bugs.python.org/issue33663

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ValeriyaSinevich
convert content length to string before putting to header
9c166f4
@the-knights-who-say-ni

the-knights-who-say-ni commented Jun 16, 2018

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

When your account is ready, please add a comment in this pull request
and a Python core developer will remove the CLA not signed label
to make the bot check again.

Thanks again for your contribution, we look forward to reviewing it!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@the-knights-who-say-ni the-knights-who-say-ni added the CLA not signed label Jun 16, 2018
@bedevere-bot bedevere-bot added the awaiting review label Jun 16, 2018
@ValeriyaSinevich
news entry
02842b6
@ValeriyaSinevich

ValeriyaSinevich commented Jun 17, 2018

Copy link
Copy Markdown
Contributor Author

CLA agreement is signed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zooba zooba added needs backport to 3.6 and removed CLA not signed labels Jun 18, 2018
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 18, 2018
@zooba

zooba commented Jun 18, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Looks good, thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zooba
zooba merged commit b36b0a3 into python:master Jun 18, 2018
@miss-islington

miss-islington commented Jun 18, 2018

Copy link
Copy Markdown
Contributor

Thanks @ValeriyaSinevich for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed awaiting review needs backport to 3.7 labels Jun 18, 2018
@bedevere-bot

bedevere-bot commented Jun 18, 2018

Copy link
Copy Markdown

GH-7781 is a backport of this pull request to the 3.7 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 18, 2018
@ValeriyaSinevich @miss-islington
bpo-33663: Convert content length to string before putting to header (p…
39bddeb 
…ythonGH-7754)

(cherry picked from commit b36b0a3)

Co-authored-by: ValeriyaSinevich <[email protected]>
@bedevere-bot

bedevere-bot commented Jun 18, 2018

Copy link
Copy Markdown

GH-7782 is a backport of this pull request to the 3.6 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.6 label Jun 18, 2018
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 18, 2018
@ValeriyaSinevich @miss-islington
bpo-33663: Convert content length to string before putting to header (p…
f7911bc 
…ythonGH-7754)

(cherry picked from commit b36b0a3)

Co-authored-by: ValeriyaSinevich <[email protected]>
miss-islington added a commit that referenced this pull request Jun 18, 2018
@miss-islington @ValeriyaSinevich
bpo-33663: Convert content length to string before putting to header (G…
53d1e9f 
…H-7754)

(cherry picked from commit b36b0a3)

Co-authored-by: ValeriyaSinevich <[email protected]>
miss-islington added a commit that referenced this pull request Jun 18, 2018
@miss-islington @ValeriyaSinevich
bpo-33663: Convert content length to string before putting to header (G…
8c19a44 
…H-7754)

(cherry picked from commit b36b0a3)

Co-authored-by: ValeriyaSinevich <[email protected]>
@rayluo

rayluo commented Jun 22, 2018

Copy link
Copy Markdown

PR looks good! Off topic: why that bot duplicated the url in the PR description? :-)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@ValeriyaSinevich @the-knights-who-say-ni @zooba @miss-islington @bedevere-bot @rayluo
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.