GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-33717: set terse=True in pythoninfo.collect_platform by zhangyangyu · Pull Request #7797 · python/cpython

Conversation

@zhangyangyu

@zhangyangyu zhangyangyu commented Jun 19, 2018 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I suggest using platform.platform(aliased=True, terse=True) in test.pythoninfo in < 3.8. This makes it more consistent with 3.8. platform.platform is largely changed in 3.8. More specially, I want libc version to be included in pythoninfo. Although libc version is wrong now but I think it will be fixed soon.

https://bugs.python.org/issue33717

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@zhangyangyu
terse=True in pythoninfo
cbb2187
@zhangyangyu zhangyangyu added needs backport to 3.6 skip issue skip news labels Jun 19, 2018
@zhangyangyu
zhangyangyu requested a review from vstinner June 19, 2018 15:28
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 19, 2018
@bedevere-bot bedevere-bot added the awaiting merge label Jun 19, 2018
@vstinner vstinner changed the title set terse=True in pythoninfo.collect_platform bpo-33717: set terse=True in pythoninfo.collect_platform Jun 19, 2018
@vstinner vstinner removed the skip issue label Jun 19, 2018
vstinner
vstinner reviewed Jun 19, 2018
View reviewed changes
Comment thread Lib/test/pythoninfo.py
platform.python_implementation())
info_add('platform.platform',
platform.platform(aliased=True))
platform.platform(aliased=True, terse=True))

@vstinner vstinner Jun 19, 2018

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like terse=True returns less information.

platform.platform(aliased=True)
'Linux-4.16.14-300.fc28.x86_64-x86_64-with-fedora-28-Twenty_Eight'
platform.platform(aliased=True,terse=True)
'Linux-4.16.14-300.fc28.x86_64-x86_64-with-glibc2.3.4'

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@zhangyangyu zhangyangyu Jun 19, 2018

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The distribution info. platform.dist is deprecated long ago and the buildbot already tells us what the exact distribution is. The info is already not available in master.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
vstinner
vstinner approved these changes Jun 19, 2018
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@zhangyangyu
zhangyangyu merged commit 71ca738 into python:3.7 Jun 19, 2018
@miss-islington

miss-islington commented Jun 19, 2018

Copy link
Copy Markdown
Contributor

Thanks @zhangyangyu for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 19, 2018
@zhangyangyu
zhangyangyu deleted the pythoninfo-platform branch June 19, 2018 17:33
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 19, 2018
@zhangyangyu @miss-islington
set terse to True when calling platform.platform in test.pythoninfo (p…
2d347f8 
…ythonGH-7797)

(cherry picked from commit 71ca738)

Co-authored-by: Xiang Zhang <[email protected]>
@bedevere-bot

bedevere-bot commented Jun 19, 2018

Copy link
Copy Markdown

GH-7802 is a backport of this pull request to the 3.6 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.6 label Jun 19, 2018
@bedevere-bot

bedevere-bot commented Jun 19, 2018

Copy link
Copy Markdown

GH-7803 is a backport of this pull request to the 2.7 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 2.7 label Jun 19, 2018
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 19, 2018
@zhangyangyu @miss-islington
set terse to True when calling platform.platform in test.pythoninfo (p…
048f32b 
…ythonGH-7797)

(cherry picked from commit 71ca738)

Co-authored-by: Xiang Zhang <[email protected]>
zhangyangyu added a commit that referenced this pull request Jun 19, 2018
@miss-islington @zhangyangyu
bpo-33717: set terse to True when calling platform.platform in test.p…
b2dd5f1 
…ythoninfo (GH-7797) (GH-7803)

(cherry picked from commit 71ca738)

Co-authored-by: Xiang Zhang <[email protected]>
zhangyangyu added a commit that referenced this pull request Jun 19, 2018
@miss-islington @zhangyangyu
bpo-33717: set terse to True when calling platform.platform in test.p…
6aa283a 
…ythoninfo (GH-7797) (GH-7802)

(cherry picked from commit 71ca738)

Co-authored-by: Xiang Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@zhangyangyu @miss-islington @bedevere-bot @vstinner @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.