GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-33904: IDLE: In rstrip, rename class RstripExtension as Rstrip by srinivasreddy · Pull Request #7811 · python/cpython

Conversation

@srinivasreddy

@srinivasreddy srinivasreddy commented Jun 20, 2018 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue33904

https://bugs.python.org/issue33904

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@srinivasreddy
IDLE: In rstrip, rename class RstripExtension as Rstrip
3e21ce9 
Signed-off-by: Srinivas Reddy Thatiparthy <[email protected]>
@srinivasreddy
srinivasreddy requested a review from terryjreedy as a code owner June 20, 2018 05:33
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 20, 2018
@bedevere-bot bedevere-bot added the awaiting review label Jun 20, 2018
@srinivasreddy srinivasreddy changed the title IDLE: In rstrip, rename class RstripExtension as Rstrip bpo-33904: IDLE: In rstrip, rename class RstripExtension as Rstrip Jun 20, 2018
terryjreedy
terryjreedy requested changes Jun 20, 2018
View reviewed changes

@terryjreedy terryjreedy left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Please add a news item, using blurb. For whatever reason, I cannot push one. Use this:
In module rstrip, rename class RstripExtension as Rstrip.

In the future, please include one with the PR. The exact content does not matter, as it can be edited via the web page, which is much easier than pulling and pushing. This is otherwise ready to merge.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting changes and removed awaiting review labels Jun 20, 2018
@bedevere-bot

bedevere-bot commented Jun 20, 2018

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be poked with soft cushions!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@terryjreedy

terryjreedy commented Jun 20, 2018

Copy link
Copy Markdown
Member

If you are looking for another easy issue, try bpo-33906.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@terryjreedy terryjreedy added needs backport to 3.6 labels Jun 20, 2018
@srinivasreddy
Add News entry
81dc36c 
Signed-off-by: Srinivas Reddy Thatiparthy <[email protected]>
terryjreedy
terryjreedy approved these changes Jun 20, 2018
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting changes labels Jun 20, 2018
@terryjreedy
terryjreedy merged commit 9bb9223 into python:master Jun 20, 2018
@miss-islington

miss-islington commented Jun 20, 2018

Copy link
Copy Markdown
Contributor

Thanks @srinivasreddy for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 20, 2018
@bedevere-bot

bedevere-bot commented Jun 20, 2018

Copy link
Copy Markdown

GH-7814 is a backport of this pull request to the 3.7 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.7 label Jun 20, 2018
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 20, 2018
@srinivasreddy @miss-islington
bpo-33904: In IDLE's rstrip, rename class RstripExtension as Rstrip (p…
2d9070c 
…ythonGH-7811)

(cherry picked from commit 9bb9223)

Co-authored-by: Srinivas Reddy Thatiparthy (శ్రీనివాస్ రెడ్డి తాటిపర్తి) <[email protected]>
@bedevere-bot

bedevere-bot commented Jun 20, 2018

Copy link
Copy Markdown

GH-7815 is a backport of this pull request to the 3.6 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.6 label Jun 20, 2018
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 20, 2018
@srinivasreddy @miss-islington
bpo-33904: In IDLE's rstrip, rename class RstripExtension as Rstrip (p…
a6414cc 
…ythonGH-7811)

(cherry picked from commit 9bb9223)

Co-authored-by: Srinivas Reddy Thatiparthy (శ్రీనివాస్ రెడ్డి తాటిపర్తి) <[email protected]>
miss-islington added a commit that referenced this pull request Jun 20, 2018
@miss-islington @srinivasreddy
bpo-33904: In IDLE's rstrip, rename class RstripExtension as Rstrip (G…
b0f3526 
…H-7811)

(cherry picked from commit 9bb9223)

Co-authored-by: Srinivas Reddy Thatiparthy (శ్రీనివాస్ రెడ్డి తాటిపర్తి) <[email protected]>
miss-islington added a commit that referenced this pull request Jun 20, 2018
@miss-islington @srinivasreddy
bpo-33904: In IDLE's rstrip, rename class RstripExtension as Rstrip (G…
b41dc56 
…H-7811)

(cherry picked from commit 9bb9223)

Co-authored-by: Srinivas Reddy Thatiparthy (శ్రీనివాస్ రెడ్డి తాటిపర్తి) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy terryjreedy approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@srinivasreddy @bedevere-bot @terryjreedy @miss-islington @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.