GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-33894: Clarified the tempdir documentation by srinivasreddy · Pull Request #7829 · python/cpython

Conversation

@srinivasreddy

@srinivasreddy srinivasreddy commented Jun 20, 2018 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue33894

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added the awaiting review label Jun 20, 2018
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 20, 2018
@srinivasreddy srinivasreddy changed the title Clarified the tempdir documentation bpo-33894: Clarified the tempdir documentation Jun 20, 2018
ericvsmith
ericvsmith requested changes Jun 20, 2018
View reviewed changes

@ericvsmith ericvsmith left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than not adding the NEWS entry, this looks good. Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Misc/NEWS.d/next/Documentation/2018-06-21-01-29-36.bpo-33894.tsesJ.rst Outdated

@ericvsmith ericvsmith Jun 20, 2018

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this merits a NEWS entry. Let's delete this file.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@srinivasreddy srinivasreddy Jun 21, 2018

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot

bedevere-bot commented Jun 20, 2018

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting changes and removed awaiting review labels Jun 20, 2018
@ericvsmith ericvsmith added needs backport to 3.6 skip news labels Jun 20, 2018
@srinivasreddy
Clarified the tempdir documentation
c5fa1ee
@srinivasreddy

srinivasreddy commented Jun 21, 2018

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Jun 21, 2018

Copy link
Copy Markdown

Thanks for making the requested changes!

@ericvsmith: please review the changes made to this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting change review and removed awaiting changes labels Jun 21, 2018
ericvsmith
ericvsmith approved these changes Jun 21, 2018
View reviewed changes

@ericvsmith ericvsmith left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the change!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting change review labels Jun 21, 2018
@ericvsmith
ericvsmith merged commit 940ae60 into python:master Jun 21, 2018
@miss-islington

miss-islington commented Jun 21, 2018

Copy link
Copy Markdown
Contributor

Thanks @srinivasreddy for the PR, and @ericvsmith for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 21, 2018
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 21, 2018
@srinivasreddy @miss-islington
Clarified the tempfile.tempdir documentation (pythonGH-7829)
03a4cad 
(cherry picked from commit 940ae60)

Co-authored-by: Srinivas Reddy Thatiparthy (శ్రీనివాస్ రెడ్డి తాటిపర్తి) <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.7 label Jun 21, 2018
@bedevere-bot

bedevere-bot commented Jun 21, 2018

Copy link
Copy Markdown

GH-7841 is a backport of this pull request to the 3.7 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Jun 21, 2018

Copy link
Copy Markdown
Contributor

Sorry, @srinivasreddy and @ericvsmith, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 940ae608566fd4446ff92a22705f646cde1d087c 2.7
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned ericvsmith Jun 21, 2018
@bedevere-bot

bedevere-bot commented Jun 21, 2018

Copy link
Copy Markdown

GH-7842 is a backport of this pull request to the 3.6 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.6 label Jun 21, 2018
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 21, 2018
@srinivasreddy @miss-islington
Clarified the tempfile.tempdir documentation (pythonGH-7829)
d124610 
(cherry picked from commit 940ae60)

Co-authored-by: Srinivas Reddy Thatiparthy (శ్రీనివాస్ రెడ్డి తాటిపర్తి) <[email protected]>
ericvsmith pushed a commit that referenced this pull request Jun 21, 2018
@miss-islington @srinivasreddy @ericvsmith
Clarified the tempfile.tempdir documentation (GH-7829) (GH-7841)
fee52e3 
(cherry picked from commit 940ae60)

Co-authored-by: Srinivas Reddy Thatiparthy (శ్రీనివాస్ రెడ్డి తాటిపర్తి) <[email protected]>
ericvsmith pushed a commit that referenced this pull request Jun 21, 2018
@miss-islington @srinivasreddy @ericvsmith
bpo-33894: Clarified the tempfile.tempdir documentation (GH-7829) (GH…
b225cb7 
…-7842)

(cherry picked from commit 940ae60)

Co-authored-by: Srinivas Reddy Thatiparthy (శ్రీనివాస్ రెడ్డి తాటిపర్తి) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericvsmith ericvsmith ericvsmith approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@ericvsmith ericvsmith

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@srinivasreddy @bedevere-bot @miss-islington @ericvsmith @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.