GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-33932: Calling Py_Initialize() twice does nothing by vstinner · Pull Request #7845 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Jun 21, 2018 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Calling Py_Initialize() twice does nothing, instead of failing with a
fatal error: restore the Python 3.6 behaviour.

https://bugs.python.org/issue33932

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
bpo-33932: Calling Py_Initialize() twice does nothing
c2728bf 
Calling Py_Initialize() twice does nothing, instead of failing with a
fatal error: restore the Python 3.6 behaviour.
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 21, 2018
@bedevere-bot bedevere-bot added the awaiting merge label Jun 21, 2018
@vstinner
vstinner requested review from ericsnowcurrently, ncoghlan and ned-deily June 21, 2018 13:32
@vstinner
Fix _Py_InitializeEx_Private()
66e0a37 
Exit early if Python is already initialized. Revert my previous
change in _Py_InitializeCore().
@vstinner

vstinner commented Jun 21, 2018

Copy link
Copy Markdown
Member Author

Oops, I didn't ran the test before pushing. Shame on my. It should be better with the second commit :-)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Jun 22, 2018

Copy link
Copy Markdown
Member Author

@serhiy-storchaka: Would you mind to have a look at this change? It seems to fix a regression introduced in Python 3.7: https://bugs.python.org/issue33932

I'm not sure that it has been made on purpose. At least, it broke an application in the wild...
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
zhangyangyu
zhangyangyu approved these changes Jun 22, 2018
View reviewed changes
@vstinner
vstinner merged commit 209abf7 into python:master Jun 22, 2018
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 22, 2018
@vstinner vstinner added awaiting merge needs backport to 3.7 labels Jun 22, 2018
@miss-islington

miss-islington commented Jun 22, 2018

Copy link
Copy Markdown
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Jun 22, 2018

Copy link
Copy Markdown

GH-7859 is a backport of this pull request to the 3.7 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.7 label Jun 22, 2018
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 22, 2018
@vstinner @miss-islington
bpo-33932: Calling Py_Initialize() twice does nothing (pythonGH-7845)
546892a 
Calling Py_Initialize() twice does nothing, instead of failing with a
fatal error: restore the Python 3.6 behaviour.
(cherry picked from commit 209abf7)

Co-authored-by: Victor Stinner <[email protected]>
@vstinner
vstinner deleted the py_init branch June 22, 2018 17:26
miss-islington added a commit that referenced this pull request Jun 22, 2018
@miss-islington @vstinner
bpo-33932: Calling Py_Initialize() twice does nothing (GH-7845)
3747dd1 
Calling Py_Initialize() twice does nothing, instead of failing with a
fatal error: restore the Python 3.6 behaviour.
(cherry picked from commit 209abf7)

Co-authored-by: Victor Stinner <[email protected]>
@Mariatta Mariatta removed the awaiting merge label Jun 25, 2018
ned-deily pushed a commit to ned-deily/cpython that referenced this pull request Jun 27, 2018
@miss-islington @vstinner @ned-deily
bpo-33932: Calling Py_Initialize() twice does nothing (pythonGH-7845)
b940921 
Calling Py_Initialize() twice does nothing, instead of failing with a
fatal error: restore the Python 3.6 behaviour.
(cherry picked from commit 209abf7)

Co-authored-by: Victor Stinner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhangyangyu zhangyangyu zhangyangyu approved these changes
@ncoghlan ncoghlan Awaiting requested review from ncoghlan
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently
@ned-deily ned-deily Awaiting requested review from ned-deily

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@vstinner @miss-islington @bedevere-bot @zhangyangyu @Mariatta @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.