GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.6] bpo-33951: IDLE test_configdialog: call page.update in setUpClass (GH-7892) by miss-islington · Pull Request #7897 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jun 24, 2018 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This avoids a failure in at least one case when running only a single
test method rather than all tests in the module.

The issue came up when testing the following on Windows 10 Pro 64-bit:
HighPageTest.test_highlight_target_text_mouse
(cherry picked from commit 2af9f5d)

Co-authored-by: Tal Einat [email protected]

https://bugs.python.org/issue33951

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@taleinat @miss-islington
bpo-33951: IDLE test_configdialog: call page.update in setUpClass (py…
0f6bfc6 
…thonGH-7892)

This avoids a failure in at least one case when running only a single
test method rather than all tests in the module.

The issue came up when testing the following on Windows 10 Pro 64-bit:
HighPageTest.test_highlight_target_text_mouse
(cherry picked from commit 2af9f5d)

Co-authored-by: Tal Einat <[email protected]>
@bedevere-bot bedevere-bot mentioned this pull request Jun 24, 2018
bpo-33951: IDLE test_configdialog: call page.update() in setUpClass #7892
Merged
@bedevere-bot bedevere-bot added the skip news label Jun 24, 2018
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 24, 2018
@bedevere-bot bedevere-bot added the awaiting review label Jun 24, 2018
terryjreedy
terryjreedy approved these changes Jun 24, 2018
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jun 24, 2018
@miss-islington

miss-islington commented Jun 24, 2018

Copy link
Copy Markdown
Contributor Author

@taleinat and @terryjreedy: Backport status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington merged commit cef5da5 into python:3.6 Jun 24, 2018
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 24, 2018
@miss-islington
miss-islington deleted the backport-2af9f5d-3.6 branch June 24, 2018 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy terryjreedy approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@miss-islington @terryjreedy @the-knights-who-say-ni @bedevere-bot @taleinat
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.