GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-33951: IDLE test_configdialog: call page.update() in setUpClass by taleinat · Pull Request #7892 · python/cpython

Conversation

@taleinat

@taleinat taleinat commented Jun 24, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This avoids a consistent failure in at least one case when running only a single test method rather than all tests in the module.

The issue came up when running the following on Windows 10 Pro 64-bit:
python -m test -ugui -m test_highlight_target_text_mouse test_idle

(This test failed for perhaps an unrelated reason on Travis CI for GH-7887. I encountered the issue while investigating that failure.)

https://bugs.python.org/issue33951

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@taleinat
test_configdialog: call page.update() in setUpClass() methods
5ff3302 
This avoids a failure in at least one case when running only a single
test method rather than all tests in the module.

The issue came up when testing the following on Windows 10 Pro 64-bit:
HighPageTest.test_highlight_target_text_mouse
@taleinat
taleinat requested a review from terryjreedy June 24, 2018 06:19
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 24, 2018
@bedevere-bot bedevere-bot added the awaiting merge label Jun 24, 2018
@taleinat taleinat mentioned this pull request Jun 24, 2018
Enable GUI testing on Travis Linux builds via Xvfb #7887
Merged
@taleinat taleinat added the skip news label Jun 24, 2018
terryjreedy
terryjreedy approved these changes Jun 24, 2018
View reviewed changes

@terryjreedy terryjreedy left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additions may or may not all be needed, but I do not believe they can hurt and the detected problem is fixed.
Thank you for thinking of this.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@terryjreedy terryjreedy self-assigned this Jun 24, 2018
@terryjreedy terryjreedy added needs backport to 3.6 labels Jun 24, 2018
@terryjreedy terryjreedy changed the title bpo-33951: test_configdialog: call page.update() in setUpClass() methods bpo-33951: IDLE test_configdialog: call page.update() in setUpClass Jun 24, 2018
@terryjreedy

terryjreedy commented Jun 24, 2018

Copy link
Copy Markdown
Member

Shorten title while adding 'IDLE'
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@terryjreedy
terryjreedy merged commit 2af9f5d into python:master Jun 24, 2018
@miss-islington

miss-islington commented Jun 24, 2018

Copy link
Copy Markdown
Contributor

Thanks @taleinat for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 24, 2018
@bedevere-bot

bedevere-bot commented Jun 24, 2018

Copy link
Copy Markdown

GH-7896 is a backport of this pull request to the 3.7 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.7 label Jun 24, 2018
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 24, 2018
@taleinat @miss-islington
bpo-33951: IDLE test_configdialog: call page.update in setUpClass (py…
256f902 
…thonGH-7892)

This avoids a failure in at least one case when running only a single
test method rather than all tests in the module.

The issue came up when testing the following on Windows 10 Pro 64-bit:
HighPageTest.test_highlight_target_text_mouse
(cherry picked from commit 2af9f5d)

Co-authored-by: Tal Einat <[email protected]>
@bedevere-bot

bedevere-bot commented Jun 24, 2018

Copy link
Copy Markdown

GH-7897 is a backport of this pull request to the 3.6 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.6 label Jun 24, 2018
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 24, 2018
@taleinat @miss-islington
bpo-33951: IDLE test_configdialog: call page.update in setUpClass (py…
0f6bfc6 
…thonGH-7892)

This avoids a failure in at least one case when running only a single
test method rather than all tests in the module.

The issue came up when testing the following on Windows 10 Pro 64-bit:
HighPageTest.test_highlight_target_text_mouse
(cherry picked from commit 2af9f5d)

Co-authored-by: Tal Einat <[email protected]>
miss-islington added a commit that referenced this pull request Jun 24, 2018
@miss-islington @taleinat
bpo-33951: IDLE test_configdialog: call page.update in setUpClass (GH…
b3bac96 
…-7892)

This avoids a failure in at least one case when running only a single
test method rather than all tests in the module.

The issue came up when testing the following on Windows 10 Pro 64-bit:
HighPageTest.test_highlight_target_text_mouse
(cherry picked from commit 2af9f5d)

Co-authored-by: Tal Einat <[email protected]>
miss-islington added a commit that referenced this pull request Jun 24, 2018
@miss-islington @taleinat
bpo-33951: IDLE test_configdialog: call page.update in setUpClass (GH…
cef5da5 
…-7892)

This avoids a failure in at least one case when running only a single
test method rather than all tests in the module.

The issue came up when testing the following on Windows 10 Pro 64-bit:
HighPageTest.test_highlight_target_text_mouse
(cherry picked from commit 2af9f5d)

Co-authored-by: Tal Einat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy terryjreedy approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@terryjreedy terryjreedy

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@taleinat @terryjreedy @miss-islington @bedevere-bot @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.