GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-33957: Doc: Use better wording by srinivasreddy · Pull Request #7912 · python/cpython

Conversation

@srinivasreddy

@srinivasreddy srinivasreddy commented Jun 25, 2018 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue33957

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 25, 2018
@bedevere-bot bedevere-bot added the awaiting review label Jun 25, 2018
@srinivasreddy srinivasreddy changed the title use correct term in place of generic wording bpo-33957: use correct term in place of generic wording Jun 25, 2018
@srinivasreddy srinivasreddy changed the title bpo-33957: use correct term in place of generic wording bpo-33957: use standard term in place of generic wording Jun 25, 2018
@methane methane changed the title bpo-33957: use standard term in place of generic wording bpo-33957: Doc: Use better wording Jun 26, 2018
@srinivasreddy
use correct term in place of generic wording
cad5a98
@srinivasreddy

srinivasreddy commented Jun 26, 2018

Copy link
Copy Markdown
Contributor Author

@methane I have rebased. Thanks a lot.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@methane

methane commented Jun 26, 2018

Copy link
Copy Markdown
Member

We don't need rebase. All commit logs are squashed when merged.
Rebase waste CI resource and prohibit reviewers review from last reviewed commit.
srinivasreddy reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@methane methane added the skip news label Jun 26, 2018
@methane
methane merged commit 866c168 into python:master Jun 26, 2018
@bedevere-bot bedevere-bot removed the awaiting review label Jun 26, 2018
@methane methane added needs backport to 3.6 labels Jun 26, 2018
@miss-islington

miss-islington commented Jun 26, 2018

Copy link
Copy Markdown
Contributor

Thanks @srinivasreddy for the PR, and @methane for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Jun 26, 2018

Copy link
Copy Markdown
Contributor

Thanks @srinivasreddy for the PR, and @methane for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Jun 26, 2018

Copy link
Copy Markdown
Contributor

Sorry, @srinivasreddy and @methane, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 866c168a5f9330d8a3ae109fa8baab2509f35cc7 3.6
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned methane Jun 26, 2018
@bedevere-bot

bedevere-bot commented Jun 26, 2018

Copy link
Copy Markdown

GH-7928 is a backport of this pull request to the 3.7 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.7 label Jun 26, 2018
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 26, 2018
@srinivasreddy @miss-islington
bpo-33957: Doc: Use better wording (pythonGH-7912)
2d4f62e 
(cherry picked from commit 866c168)

Co-authored-by: Srinivas Reddy Thatiparthy (శ్రీనివాస్ రెడ్డి తాటిపర్తి) <[email protected]>
@methane methane removed the needs backport to 3.6 label Jun 26, 2018
@srinivasreddy

srinivasreddy commented Jun 26, 2018

Copy link
Copy Markdown
Contributor Author

@methane i am not aware of that. Thanks a lot .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington added a commit that referenced this pull request Jun 26, 2018
@miss-islington @srinivasreddy
bpo-33957: Doc: Use better wording (GH-7912)
829b766 
(cherry picked from commit 866c168)

Co-authored-by: Srinivas Reddy Thatiparthy (శ్రీనివాస్ రెడ్డి తాటిపర్తి) <[email protected]>
@srinivasreddy
srinivasreddy deleted the correct branch November 1, 2018 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@methane methane

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@srinivasreddy @methane @miss-islington @bedevere-bot @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.