GeezerVison

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

I have made the requested changes; please review again.

@ezio-melotti I kept exceptions, but let me know if you want me to replace them with return -1 instead.

Thanks for making the requested changes!

@ezio-melotti: please review the changes made to this pull request.

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 FreeBSD Shared 3.x has failed when building commit e34bbfd.

What do you need to do:

1. Don't panic.
2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/152/builds/1153) and take a look at the build logs.
4. Check if the failure is related to this commit (e34bbfd) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/152/builds/1153

Failed tests:

• test_asyncio

Failed subtests:

• test_call_later - test.test_asyncio.test_events.PollEventLoopTests

Summary of the results of the build (if available):

==

Traceback (most recent call last):
  File "/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/test/test_asyncio/test_events.py", line 301, in test_call_later
    self.assertTrue(0.08 <= t1-t0 <= 0.8, t1-t0)
AssertionError: False is not true : 0.00010797599679790437

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot PPC64LE RHEL8 LTO + PGO 3.x has failed when building commit e34bbfd.

What do you need to do:

1. Don't panic.
2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/450/builds/693) and take a look at the build logs.
4. Check if the failure is related to this commit (e34bbfd) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/450/builds/693

Failed tests:

• test_ftplib

Failed subtests:

• test_nlst - test.test_ftplib.TestFTPClass

Summary of the results of the build (if available):

== Tests result: FAILURE then ENV CHANGED ==

408 tests OK.

10 slowest tests:

• test_peg_generator: 6 min 26 sec
• test_concurrent_futures: 2 min 59 sec
• test_multiprocessing_spawn: 1 min 15 sec
• test_tokenize: 1 min 14 sec
• test_multiprocessing_forkserver: 1 min 3 sec
• test_asyncio: 56.4 sec
• test_multiprocessing_fork: 54.7 sec
• test_lib2to3: 47.4 sec
• test_signal: 46.8 sec
• test_unparse: 45.9 sec

1 test altered the execution environment:
test_asyncio

14 tests skipped:
test_devpoll test_gdb test_ioctl test_kqueue test_msilib
test_ossaudiodev test_startfile test_tix test_tk test_ttk_guionly
test_winconsoleio test_winreg test_winsound test_zipfile64

1 re-run test:
test_ftplib

Total duration: 6 min 47 sec

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le.lto-pgo/build/Lib/test/test_ftplib.py", line 630, in test_nlst
    self.client.nlst()
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le.lto-pgo/build/Lib/ftplib.py", line 546, in nlst
    self.retrlines(cmd, files.append)
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le.lto-pgo/build/Lib/ftplib.py", line 458, in retrlines
    line = fp.readline(self.maxline + 1)
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le.lto-pgo/build/Lib/socket.py", line 704, in readinto
    return self._sock.recv_into(b)
socket.timeout: timed out