GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [2.7] bpo-29565: Corrected ctypes passing of large structs by value on Windows AMD64. (#168) by vstinner · Pull Request #8625 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Aug 2, 2018 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Fixed bpo-29565: Corrected ctypes passing of large structs by value.

Added code and test to check that when a structure passed by value
is large enough to need to be passed by reference, a copy of the
original structure is passed. The callee updates the passed-in value,
and the test verifies that the caller's copy is unchanged. A similar
change was also added to the test added for bpo-20160 (that test was
passing, but the changes should guard against regressions).

(cherry picked from commit a86339b)

https://bugs.python.org/issue29565

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@vsajip @vstinner
Fixed bpo-29565: Corrected ctypes passing of large structs by value o…
2425a58
…n Windows AMD64. (#168)

* Fixed bpo-29565: Corrected ctypes passing of large structs by value.

Added code and test to check that when a structure passed by value
is large enough to need to be passed by reference, a copy of the
original structure is passed. The callee updates the passed-in value,
and the test verifies that the caller's copy is unchanged. A similar
change was also added to the test added for bpo-20160 (that test was
passing, but the changes should guard against regressions).

* Reverted unintended whitespace changes.

(cherry picked from commit a86339b)
@bedevere-bot bedevere-bot added the type-bug An unexpected behavior, bug, or error label Aug 2, 2018
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Aug 2, 2018
@bedevere-bot bedevere-bot added the awaiting merge label Aug 2, 2018
@vstinner vstinner added the skip news label Aug 2, 2018
@vstinner
vstinner requested a review from vsajip August 2, 2018 14:04
@vstinner
vstinner merged commit 3243f8c into python:2.7 Aug 2, 2018
@bedevere-bot bedevere-bot removed the awaiting merge label Aug 2, 2018
@vstinner
vstinner deleted the ctypes_arm64 branch August 2, 2018 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vsajip vsajip Awaiting requested review from vsajip

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@vstinner @the-knights-who-say-ni @bedevere-bot @vsajip
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.