GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fixed bpo-29565: Corrected ctypes passing of large structs by value on Windows AMD64. by vsajip · Pull Request #168 · python/cpython

Conversation

@vsajip

@vsajip vsajip commented Feb 19, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Added code and test to check that when a structure passed by value
is large enough to need to be passed by reference, a copy of the
original structure is passed. The callee updates the passed-in value,
and the test verifies that the caller's copy is unchanged. A similar
change was also added to the test added for bpo-20160 (that test was
passing, but the changes should guard against regressions).

Thanks to Eryk Sun for the patch.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@vsajip
Fixed bpo-29565: Corrected ctypes passing of large structs by value.
9f86ced
Added code and test to check that when a structure passed by value
is large enough to need to be passed by reference, a copy of the
original structure is passed. The callee updates the passed-in value,
and the test verifies that the caller's copy is unchanged. A similar
change was also added to the test added for bpo-20160 (that test was
passing, but the changes should guard against regressions).
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 19, 2017
@vsajip vsajip changed the title Fixed bpo-29565: Corrected ctypes passing of large structs by value. Fixed bpo-29565: Corrected ctypes passing of large structs by value on Windows AMD64. Feb 19, 2017
@serhiy-storchaka serhiy-storchaka added the type-bug An unexpected behavior, bug, or error label Feb 19, 2017
@vsajip
Reverted unintended whitespace changes.
a0882ca
zooba
zooba approved these changes Feb 19, 2017
View reviewed changes
@vsajip
vsajip merged commit a86339b into python:master Feb 20, 2017
@vsajip
vsajip deleted the fix-29565 branch February 20, 2017 00:16
@berkerpeksag berkerpeksag added needs backport to 3.5 labels Feb 20, 2017
This was referenced Feb 21, 2017
Fixed bpo-29565: Corrected ctypes passing of large structs by value o… #220
Merged
Fixed bpo-29565: Corrected ctypes passing of large structs by value o… #221
Merged
vsajip added a commit that referenced this pull request Feb 22, 2017
@vsajip
Fixed bpo-29565: Corrected ctypes passing of large structs by value o…
8fa7e22
…n Windows AMD64. (#168) (#221)

Fixed bpo-29565: Corrected ctypes passing of large structs by value.
(cherry picked from commit a86339b)
vsajip added a commit that referenced this pull request Feb 22, 2017
@vsajip
Fixed bpo-29565: Corrected ctypes passing of large structs by value o…
3cc5817
…n Windows AMD64. (#168) (#220)

Fixed bpo-29565: Corrected ctypes passing of large structs by value.
(cherry picked from commit a86339b)
@vsajip vsajip removed needs backport to 3.5 labels Feb 22, 2017
vstinner added a commit that referenced this pull request Aug 2, 2018
@vstinner
bpo-29565: Corrected ctypes passing of large structs by value on Wind…
3243f8c
…ows AMD64 (GH-168) (GH-8625)

Fixed bpo-29565: Corrected ctypes passing of large structs by value.

Added code and test to check that when a structure passed by value
is large enough to need to be passed by reference, a copy of the
original structure is passed. The callee updates the passed-in value,
and the test verifies that the caller's copy is unchanged. A similar
change was also added to the test added for bpo-20160 (that test was
passing, but the changes should guard against regressions).

(cherry picked from commit a86339b)
akruis added a commit to akruis/cpython that referenced this pull request Aug 16, 2018
@akruis
Stackless issue python#168: make Stackless compatible with old Cython…
5570a39
… modules

Many extension modules were created by Cython versions before commit
037bcf0 and were compiled with regular C-Python. These modules call
PyEval_EvalFrameEx() with a broken frame object.
This commit add code to recover a broken frame in PyEval_EvalFrameEx().
akruis added a commit to akruis/cpython that referenced this pull request Aug 16, 2018
@akruis
Stackless issue python#168: make Stackless compatible with old Cython…
1d74c3b
… modules

Many extension modules were created by Cython versions before commit
037bcf0 and were compiled with regular C-Python. These modules call
PyEval_EvalFrameEx() with a broken frame object.
This commit add code to recover a broken frame in PyEval_EvalFrameEx().
akruis added a commit to akruis/cpython that referenced this pull request Aug 18, 2018
@akruis
Stackless issue python#168: make Stackless compatible with old Cython…
d680e72
… modules

Add a test case for a pathological situation.
akruis added a commit to akruis/cpython that referenced this pull request Aug 18, 2018
@akruis
Stackless issue python#168: make Stackless compatible with old Cython…
287233e
… modules

Add a test case for a pathological situation.
akruis added a commit to akruis/cpython that referenced this pull request Sep 1, 2018
@akruis
Stackless issue python#168: make Stackless compatible with old Cython…
3e04fca
… modules

Add another test case for a pathological situation.
akruis added a commit to akruis/cpython that referenced this pull request Sep 3, 2018
@akruis
Stackless issue python#168: make Stackless compatible with old Cython…
0f57156
… modules

Add another test case for a pathological situation.
akruis pushed a commit to akruis/cpython that referenced this pull request Sep 11, 2018
Anselm Kruis @akruis
Stackless issue python#168: make Stackless compatible with old Cython…
a05b5e5
… modules (python#170)

Many extension modules were created by Cython versions before commit
037bcf0 and were compiled with regular C-Python. These modules call
PyEval_EvalFrameEx() with a broken frame object.
This commit add code to recover a broken frame in PyEval_EvalFrameEx().

(cherry picked from commit f9094d2)
akruis pushed a commit to akruis/cpython that referenced this pull request Oct 14, 2018
Anselm Kruis
Stackless issue python#168: make Stackless compatible with old Cython…
f9094d2
… modules (python#170)

Many extension modules were created by Cython versions before commit
037bcf0 and were compiled with regular C-Python. These modules call
PyEval_EvalFrameEx() with a broken frame object.
This commit add code to recover a broken frame in PyEval_EvalFrameEx().
akruis pushed a commit to akruis/cpython that referenced this pull request Feb 18, 2019
Anselm Kruis
Stackless issue python#168: make Stackless compatible with old Cython…
638e61c
… modules (python#169)

Many extension modules were created by Cython versions before commit
037bcf0 and were compiled with regular C-Python. These modules call
PyEval_EvalFrameEx() with a broken frame object.
This commit add code to recover a broken frame in PyEval_EvalFrameEx().
isidentical added a commit to isidentical/cpython that referenced this pull request Oct 15, 2021
@isidentical
separate raw_expressions / new expressions cursors (python#168)
435fead
jaraco pushed a commit that referenced this pull request Dec 2, 2022
@Mariatta
Debug ratelimit info (#168)
ad79cc1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zooba zooba zooba approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@vsajip @zooba @berkerpeksag @serhiy-storchaka @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.