GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-33898: Fix pathlib issues with Windows device paths by AlbinaGiliazova · Pull Request #8671 · python/cpython

Conversation

@AlbinaGiliazova

@AlbinaGiliazova AlbinaGiliazova commented Aug 4, 2018 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

https://bugs.python.org/issue33898
Now it should work correctly for all mentioned test examples but no changes made for GlobalRoot case as no examples were provided.

https://bugs.python.org/issue33898

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
AlbinaGiliazova added 2 commits August 4, 2018 13:47
@AlbinaGiliazova
Update pathlib.py
245381a
@AlbinaGiliazova
bpo-33898: Fix pathlib issues
2ed69c3
@the-knights-who-say-ni

the-knights-who-say-ni commented Aug 4, 2018

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

When your account is ready, please add a comment in this pull request
and a Python core developer will remove the CLA not signed label
to make the bot check again.

You can check yourself
to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@the-knights-who-say-ni the-knights-who-say-ni added the CLA not signed label Aug 4, 2018
@bedevere-bot bedevere-bot added the awaiting review label Aug 4, 2018
AlbinaGiliazova added 8 commits August 4, 2018 15:11
@AlbinaGiliazova
Create 2018-08-04-15-04-10.bpo-33898.psrYKd.rst
9f6cf13
@AlbinaGiliazova
Merge pull request #2 from AlbinaGiliazova/Info-entry
2a3c396
Create 2018-08-04-15-04-10.bpo-33898.psrYKd.rst
@AlbinaGiliazova
Whitespace check
993d016
@AlbinaGiliazova
More whitespace
c34a192
@AlbinaGiliazova
Again whitespace
7bd8f58
@AlbinaGiliazova
Update pathlib.py
cd128fa
@AlbinaGiliazova
Delete pathlib.py
fde7f88
@AlbinaGiliazova
no .upper()
3fc6092
@AlbinaGiliazova

AlbinaGiliazova commented Aug 5, 2018

Copy link
Copy Markdown
Author

Wow! It passed whitespace checks finally. I thought it's impossible. Btw CLA is signed but waiting for approvement.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

zooba
zooba reviewed Aug 7, 2018
View reviewed changes

@zooba zooba left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this patch! A couple of minor suggestions, and a question or two.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread Lib/pathlib.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Lib/pathlib.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Lib/pathlib.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Lib/pathlib.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Lib/pathlib.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Lib/pathlib.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

@zooba zooba removed the CLA not signed label Aug 7, 2018
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Aug 7, 2018
AlbinaGiliazova added 5 commits August 9, 2018 22:52
@AlbinaGiliazova
Update pathlib.py
af842d3
@AlbinaGiliazova
whitespace
b6b8f2c
@AlbinaGiliazova
whitespace
f4a0ef0
@AlbinaGiliazova
fix
8d050b8
@AlbinaGiliazova
Update pathlib.py
4a5d84d
@AlbinaGiliazova

AlbinaGiliazova commented Aug 14, 2018

Copy link
Copy Markdown
Author

I've made the improvements requested. Should I do something else or just wait for another review?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@csabella

csabella commented Feb 16, 2019

Copy link
Copy Markdown
Contributor

@zooba It appears that @AlbinaGiliazova addressed all your review concerns. Would you have an opportunity to review the changes? Thanks!

AlbinaGiliazova reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

zooba
zooba reviewed Feb 17, 2019
View reviewed changes

@zooba zooba left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the ping! We're nearly there, just little nits that we don't want making it into the codebase.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

csabella reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Comment thread Lib/pathlib.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Lib/pathlib.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Lib/pathlib.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Lib/pathlib.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Lib/pathlib.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

zooba and others added 2 commits March 7, 2019 08:47
@zooba
Apply code review feedback
4dc62db
@zooba
Fixes indentation
14bed13
@zooba zooba added OS-windows needs backport to 3.7 labels Mar 7, 2019
@csabella

csabella commented May 23, 2019

Copy link
Copy Markdown
Contributor

@eryksun, would you be able to review this per @zooba's request on the bug tracker. Thanks!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@eryksun

eryksun commented May 24, 2019

Copy link
Copy Markdown
Contributor

@csabella, thanks for the reminder. I missed the tracker notification.

csabella reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@csabella csabella added the needs backport to 3.8 label Jan 18, 2020
@csabella

csabella commented Jan 18, 2020

Copy link
Copy Markdown
Contributor

@eryksun, ping

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@AlbinaGiliazova

AlbinaGiliazova commented May 16, 2020

Copy link
Copy Markdown
Author

Hello. How do I make backports. Is there an instruction?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@csabella csabella assigned eryksun May 23, 2020
@csabella csabella added the needs backport to 3.9 label May 23, 2020
@csabella

csabella commented May 23, 2020

Copy link
Copy Markdown
Contributor

@AlbinaGiliazova, you wouldn't need to do anything for the backports unless the bot is unable to create them.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ambv ambv removed needs backport to 3.7 labels May 4, 2021
@barneygale

barneygale commented May 17, 2021

Copy link
Copy Markdown
Contributor

Code looks good to me, but this needs tests!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ambv

ambv commented May 17, 2022

Copy link
Copy Markdown
Contributor

This missed the boat for inclusion in Python 3.9 which accepts security fixes only as of today.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ambv ambv removed the needs backport to 3.9 label May 17, 2022
@brettcannon brettcannon added the topic-pathlib label Jun 21, 2022
@eryksun eryksun mentioned this pull request Jun 21, 2022
[pathlib] issues with Windows device paths #78079
Closed
@ezio-melotti ezio-melotti removed the CLA signed label Jul 13, 2022
@barneygale

barneygale commented Apr 17, 2023

Copy link
Copy Markdown
Contributor

Thanks for this PR, @AlbinaGiliazova! The issue has now been resolved by another PR, so I'll close this PR. Hope that's alright, thanks again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@barneygale barneygale closed this Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zooba zooba zooba left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@eryksun eryksun

Labels

awaiting review OS-windows topic-pathlib

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

10 participants

@AlbinaGiliazova @the-knights-who-say-ni @csabella @eryksun @barneygale @ambv @zooba @brettcannon @ezio-melotti @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.