GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||
GeezerVison is showing github.com — bpo-33898: Fix pathlib issues with Windows device paths by AlbinaGiliazova · Pull Request #8671 · python/cpython Conversation
|
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. When your account is ready, please add a comment in this pull request You can check yourself Thanks again for your contribution, we look forward to reviewing it! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Create 2018-08-04-15-04-10.bpo-33898.psrYKd.rst
|
Wow! It passed whitespace checks finally. I thought it's impossible. Btw CLA is signed but waiting for approvement. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this patch! A couple of minor suggestions, and a question or two.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
I've made the improvements requested. Should I do something else or just wait for another review? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@zooba It appears that @AlbinaGiliazova addressed all your review concerns. Would you have an opportunity to review the changes? Thanks! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the ping! We're nearly there, just little nits that we don't want making it into the codebase.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
@csabella, thanks for the reminder. I missed the tracker notification. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@eryksun, ping |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Hello. How do I make backports. Is there an instruction? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@AlbinaGiliazova, you wouldn't need to do anything for the backports unless the bot is unable to create them. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Code looks good to me, but this needs tests! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
This missed the boat for inclusion in Python 3.9 which accepts security fixes only as of today. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks for this PR, @AlbinaGiliazova! The issue has now been resolved by another PR, so I'll close this PR. Hope that's alright, thanks again. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.