GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-33898: Fix pathlib issues with Windows device paths by AlbinaGiliazova · Pull Request #8671 · python/cpython

bpo-33898: Fix pathlib issues with Windows device paths #8671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AlbinaGiliazova wants to merge 17 commits into python:main from AlbinaGiliazova:bpo-33898-fix

Uh oh!

There was an error while loading. Please reload this page.
Closed

bpo-33898: Fix pathlib issues with Windows device paths #8671

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
245381a
Update pathlib.py
AlbinaGiliazova Aug 4, 2018
2ed69c3
bpo-33898: Fix pathlib issues
AlbinaGiliazova Aug 4, 2018
9f6cf13
Create 2018-08-04-15-04-10.bpo-33898.psrYKd.rst
AlbinaGiliazova Aug 4, 2018
2a3c396
Merge pull request #2 from AlbinaGiliazova/Info-entry
AlbinaGiliazova Aug 4, 2018
993d016
Whitespace check
AlbinaGiliazova Aug 4, 2018
c34a192
More whitespace
AlbinaGiliazova Aug 4, 2018
7bd8f58
Again whitespace
AlbinaGiliazova Aug 5, 2018
cd128fa
Update pathlib.py
AlbinaGiliazova Aug 5, 2018
fde7f88
Delete pathlib.py
AlbinaGiliazova Aug 5, 2018
3fc6092
no .upper()
AlbinaGiliazova Aug 5, 2018
af842d3
Update pathlib.py
AlbinaGiliazova Aug 9, 2018
b6b8f2c
whitespace
AlbinaGiliazova Aug 9, 2018
f4a0ef0
whitespace
AlbinaGiliazova Aug 9, 2018
8d050b8
fix
AlbinaGiliazova Aug 9, 2018
4a5d84d
Update pathlib.py
AlbinaGiliazova Aug 10, 2018
4dc62db
Apply code review feedback
zooba Mar 7, 2019
14bed13
Fixes indentation
zooba Mar 7, 2019
File filter
Filter by extension
Clear filters
Conversations
Failed to load comments.
Loading

Uh oh!

There was an error while loading. Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading

Uh oh!

There was an error while loading. Please reload this page.
Diff view
Diff view
Prev Previous commit
Next Next commit
no .upper()
  • Loading branch information

Uh oh!

There was an error while loading. Please reload this page.

@AlbinaGiliazova
AlbinaGiliazova authored Aug 5, 2018
commit 3fc6092b42f4936fe3b2ce97ae2e331db9c6f029

There are no files selected for viewing

5 changes: 3 additions & 2 deletions 5 Lib/pathlib.py
Show comments
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,8 +224,9 @@ def _split_extended_path(self, s, ext_prefix=ext_namespace_prefix,\
if index != -1:
# Do not assume case sensitivity.
# See https://docs.microsoft.com/ru-ru/windows/desktop/FileIO/naming-a-file
Comment thread
zooba marked this conversation as resolved.
Resolved

Uh oh!

There was an error while loading. Please reload this page.
s1 = s[:index].upper()
if s1 == 'GLOBAL':
# But .lower() is not recommended. See https://bugs.python.org/issue32612
s1 = s[:index]
if s1 == 'Global' or s1 == 'GLOBAL':
Comment thread
zooba marked this conversation as resolved.
Resolved

Uh oh!

There was an error while loading. Please reload this page.
prefix += s[:6]
# For example, Path('//?/Global/Z:/').drive
Comment thread
zooba marked this conversation as resolved.
Resolved

Uh oh!

There was an error while loading. Please reload this page.
if s[8] == ':':
Comment thread
zooba marked this conversation as resolved.
Resolved

Uh oh!

There was an error while loading. Please reload this page.
Expand Down
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.