GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.6] bpo-29643: Fix check for --enable-optimizations by methane · Pull Request #869 · python/cpython

Conversation

@methane

@methane methane commented Mar 28, 2017

Copy link
Copy Markdown
Member

(cherry picked from commit 8cea592)
(Original pull request is GH-129)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ts826848 and others added 2 commits March 28, 2017 21:52
@ts826848 @methane
bpo-29643: Fix check for --enable-optimizations (GH-129)
c65e7cb 
The presence of the ``--enable-optimizations`` flag is indicated by the
value of ``$enableval``, but the configure script was checking ``$withval``,
resulting in the ``--enable-optimizations`` flag being effectively ignored.
(cherry picked from commit 8cea592)
@methane
fix news
17997b0
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 28, 2017
@vstinner vstinner mentioned this pull request Mar 28, 2017
bpo-29643: Fix check for --enable-optimizations (GH-129) #870
Closed
vstinner
vstinner approved these changes Mar 28, 2017
View reviewed changes
@methane
methane merged commit f01de61 into python:3.6 Mar 28, 2017
@methane
methane deleted the backport-gh129-36 branch March 28, 2017 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@methane @vstinner @the-knights-who-say-ni @ts826848
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.