GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — bpo-29643: Fix check for --enable-optimizations by ts826848 · Pull Request #129 · python/cpython

Conversation

ts826848 commented Feb 16, 2017

Copy link

Copy Markdown

Contributor

The presence of the --enable-optimizations flag is indicated by the
value of $enableval, but the configure script was checking $withval,
resulting in the --enable-optimizations flag being effectively ignored.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          configure: Fix check for --enable-optimizations

1624d15

The presence of the --enable-optimizations flag is indicated by the
value of $enableval, but the configure script was checking $withval,
resulting in the --enable-optimizations flag being effectively ignored.

the-knights-who-say-ni commented Feb 16, 2017

Copy link

Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA. This is necessary for legal reasons before we can look at your contribution. Please follow these steps to help rectify the issue:

If you don't have an account on b.p.o, please create one
Make sure your GitHub username is listed in "Your Details" at b.p.o
If you have not already done so, please sign the PSF contributor agreement
If you just signed the CLA, please wait at least one US business day and then check "Your Details" on bugs.python.org to see if your account has been marked as having signed the CLA (the delay is due to a person having to manually check your signed CLA)
Reply here saying you have completed the above steps

Thanks again to your contribution and we look forward to looking at it!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

the-knights-who-say-ni added the CLA not signed label

Feb 16, 2017

Mariatta removed the CLA not signed label

Feb 18, 2017

the-knights-who-say-ni added the CLA signed label

Feb 18, 2017

ts826848 commented Feb 20, 2017 via email

Copy link

Copy Markdown

Contributor Author

I have signed the CLA.

…

On Feb 16, 2017, at 12:57 AM, the-knights-who-say-ni ***@***.***> wrote: Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement <https://www.python.org/psf/contrib/contrib-form/> (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org <http://bugs.python.org/> (b.p.o) to verify you have signed the CLA. This is necessary for legal reasons before we can look at your contribution. Please follow these steps to help rectify the issue: If you don't have an account on b.p.o, please create one ***@***.***=register> Make sure your GitHub username is listed in "Your Details" at b.p.o <https://cloud.githubusercontent.com/assets/2680980/22867185/d3aedcf8-f137-11e6-8469-d5f7861a1073.png> If you have not already done so, please sign the PSF contributor agreement <https://www.python.org/psf/contrib/contrib-form/> If you just signed the CLA, please wait at least one US business day and then check "Your Details" on bugs.python.org <https://bugs.python.org/> to see if your account has been marked as having signed the CLA (the delay is due to a person having to manually check your signed CLA) Reply here saying you have completed the above steps Thanks again to your contribution and we look forward to looking at it! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#129 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAilLLVQvNG2dm0Gp9C0pmXkbZW2LudLks5rc-VFgaJpZM4MCnaf>.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

zhangyangyu commented Feb 22, 2017

Copy link

Copy Markdown

Member

It would be nice to open an issue on http://bugs.python.org/ to track this problem. And don't forget to nosy @brettcannon .

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

brettcannon requested a review from gpshead

February 24, 2017 23:11

brettcannon added needs backport to 3.6 labels

Feb 24, 2017

brettcannon commented Feb 24, 2017

Copy link

Copy Markdown

Member

My Makefile knowledge is fairly limited so I'm adding @gpshead to see if he is up for reviewing. If not then I can handle it.

And can you open an issue on bugs.python.org for this, @aw1621107 ?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ts826848 commented Feb 24, 2017

Copy link

Copy Markdown

Contributor Author

Oops, forgot about that. Submitted issue 29643. Sorry about the delay.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

brettcannon added the needs backport to 2.7 label

Feb 24, 2017

brettcannon changed the title ~~configure: Fix check for --enable-optimizations~~ bpo-29643: Fix check for --enable-optimizations

Feb 24, 2017

gpshead commented Mar 11, 2017

Copy link

Copy Markdown

Member

thanks, this change looks good.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

gpshead commented Mar 11, 2017

Copy link

Copy Markdown

Member

When checking it in, we need to check in regenerated configure files along with it. but that could make easy backporting/merging a pain. do we have a process preference for configure.ac & configure changes? or just leave it up to whomever is merging?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

brettcannon commented Mar 11, 2017

Copy link

Copy Markdown

Member

@gpshead I think we have a version requirement specified in configure.ac, but otherwise the committer just runs autoconf and commits both configure.ac and configure.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

the-knights-who-say-ni added CLA not signed and removed CLA signed labels

Mar 27, 2017

methane added 2 commits

March 27, 2017 17:38


          Merge remote-tracking branch 'origin/master' into aw1621107-patch-1


          autoreconf

5ab7e5b

the-knights-who-say-ni added CLA signed and removed CLA not signed labels

Mar 27, 2017

methane commented Mar 27, 2017

Copy link

Copy Markdown

Member

I'm sorry. I failed to merge master and I used push --force to solve it.
If curious notify sent to you, please ignore it.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

methane commented Mar 27, 2017

Copy link

Copy Markdown

Member

When I ran autoreconf, unrelated changes (pkg-config 0.29 -> 0.29.2) happens.
Should I remove the change?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ned-deily commented Mar 27, 2017

Copy link

Copy Markdown

Member

@methane: The change to aclocal.m4 should not matter one way or another. You can leave it in or not.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

methane added 2 commits

March 28, 2017 20:49


          revert aclocal.m4 changes

2469c24


          Add news entry

7d08056

methane merged commit 8cea592 into python:master

Mar 28, 2017

methane referenced this pull request in methane/cpython

Mar 28, 2017


          bpo-29643: Fix check for --enable-optimizations (GH-129)

c65e7cb

The presence of the ``--enable-optimizations`` flag is indicated by the
value of ``$enableval``, but the configure script was checking ``$withval``,
resulting in the ``--enable-optimizations`` flag being effectively ignored.
(cherry picked from commit 8cea592)

methane mentioned this pull request

Mar 28, 2017

[3.6] bpo-29643: Fix check for --enable-optimizations #869

Merged

vstinner pushed a commit that referenced this pull request

Mar 28, 2017


          bpo-29643: Fix check for --enable-optimizations (GH-129)

59eb1ab

The presence of the ``--enable-optimizations`` flag is indicated by the
value of ``$enableval``, but the configure script was checking ``$withval``,
resulting in the ``--enable-optimizations`` flag being effectively ignored.
(cherry picked from commit 8cea592)

methane referenced this pull request in methane/cpython

Mar 28, 2017


          bpo-29643: Fix check for --enable-optimizations (GH-129)

fc53fda

The presence of the ``--enable-optimizations`` flag is indicated by the
value of ``$enableval``, but the configure script was checking ``$withval``,
resulting in the ``--enable-optimizations`` flag being effectively ignored.
(cherry picked from commit 8cea592)

This was referenced Mar 28, 2017

[3.5] bpo-29643: Fix check for --enable-optimizations #871

Merged

[2.7] bpo-29643: Fix check for --enable-optimizations #873

Merged

methane removed needs backport to 3.5 labels

Mar 28, 2017

Mariatta removed the needs backport to 2.7 label

Mar 31, 2017

duggelz mentioned this pull request

Apr 7, 2017

uwsgi fails to build/install GoogleCloudPlatform/python-runtime#96

Closed

akruis referenced this pull request in stackless-dev/stackless

Sep 5, 2017


          merge 3.4-slp (Stackless #129, PyTasklet_New( NULL, ...))

fa700f6

akruis pushed a commit to akruis/cpython that referenced this pull request

Sep 9, 2017


          merge 3.3-slp (Stackless python#129, PyTasklet_New( NULL, ...))

ba5cf46

akruis pushed a commit to akruis/cpython that referenced this pull request

Sep 9, 2017


          Issue python#129: fix calling PyTasklet_New( NULL, ...)

3a45703

Re-add the test for NULL. It got lost in change 20dad21ded9c (2.7-slp) and dae0e80f141d (3.2-slp). Update the documentation.

https://bitbucket.org/stackless-dev/stackless/issues/129
(grafted from a4dfdadc7cf547e7f589e8191b8bab2c67e34f00)

akruis pushed a commit to akruis/cpython that referenced this pull request

Oct 10, 2017


          merge 3.5-slp (Stackless python#129, PyTasklet_New( NULL, ...))

fb4bc09

pablogsal referenced this pull request in pablogsal/cpython

Aug 13, 2022


          Implement soft keywords (hand-written and code generation) (#129)

a10babb

pablogsal mentioned this pull request

Aug 13, 2022

bpo-40222: Mark exception table function in the dis module as private #95960

Closed

jaraco pushed a commit that referenced this pull request

Dec 2, 2022


          Update pytest from 3.6.4 to 3.7.1 (#129)

7371ffa

lazka added a commit to lazka/cpython that referenced this pull request

Mar 2, 2023


          fixup! CI: test the build and add some mingw specific tests

eb44c35

missing ref on the return value

Fixes python#129

lazka added a commit to lazka/cpython that referenced this pull request

Apr 7, 2023


          fixup! CI: test the build and add some mingw specific tests

94fd053

missing ref on the return value

Fixes python#129

gvanrossum mentioned this pull request

Aug 22, 2023

heap-use-after-free in _PyFunction_LookupByVersion #108253

Closed

This was referenced Feb 11, 2025

segmentfault when pip installing setuptools #129992

Closed

segmentfault when pip installing setuptools #129993

Closed

Reviewers

gpshead

Awaiting requested review from gpshead

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.