GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [2.7] bpo-29643: Fix check for --enable-optimizations by methane · Pull Request #873 · python/cpython

Conversation

@methane

@methane methane commented Mar 28, 2017

Copy link
Copy Markdown
Member

The presence of the --enable-optimizations flag is indicated by the
value of $enableval, but the configure script was checking $withval,
resulting in the --enable-optimizations flag being effectively ignored.
(cherry picked from commit 8cea592)
(original pull request is GH-129)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ts826848 @methane
bpo-29643: Fix check for --enable-optimizations (GH-129)
bbf9f0a 
The presence of the ``--enable-optimizations`` flag is indicated by the
value of ``$enableval``, but the configure script was checking ``$withval``,
resulting in the ``--enable-optimizations`` flag being effectively ignored.
(cherry picked from commit 8cea592)
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 28, 2017
@methane
Update NEWS
b4a6168
@methane
methane merged commit 6a04ef7 into python:2.7 Mar 28, 2017
@methane
methane deleted the backport-gh129-27 branch March 28, 2017 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@methane @the-knights-who-say-ni @ts826848
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.