GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — bpo-34392: Add sys. _is_interned() by serhiy-storchaka · Pull Request #8755 · python/cpython

Conversation

serhiy-storchaka commented Aug 13, 2018 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

https://bugs.python.org/issue34392

#78573

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          bpo-34392: Add sys.isinterned().

dea574c

serhiy-storchaka added the type-feature A feature request or enhancement label

Aug 13, 2018

the-knights-who-say-ni added the CLA signed label

Aug 13, 2018

bedevere-bot added the awaiting merge label

Aug 13, 2018

pablogsal reviewed

Aug 13, 2018

View reviewed changes

Comment thread

Python/sysmodule.c

		sys_isinterned_impl(PyObject module, PyObject string)
		/[clinic end generated code: output=0364c3f36499f868 input=2fe09bef8edf732e]/
		{
		return PyUnicode_CHECK_INTERNED(string);

pablogsal Aug 13, 2018

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Currently sys.internmakes a PyUnicode_CheckExact(s) over the string so interning a subclass of a string gives a TypeError back. This returns False. Does it make sense to do a exact check to mirror the interface of sys.intern?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

serhiy-storchaka Aug 19, 2018

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

serhiy-storchaka added 2 commits

August 19, 2018 09:52


          Rename to sys._is_interned().

7b91698


          Merge branch 'master' into sys-isinterned

methane approved these changes

Mar 28, 2019

View reviewed changes

csabella commented May 25, 2020

Copy link

Copy Markdown

Contributor

@methane, should this be merged after fixing the merge conflicts? Thanks!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

methane changed the title ~~bpo-34392: Add sys.isinterned().~~ bpo-34392: Add sys. _is_interned()

May 26, 2020

methane commented May 26, 2020

Copy link

Copy Markdown

Member

@methane, should this be merged after fixing the merge conflicts? Thanks!

Up to @serhiy-storchaka. He wanted this API to write some tests.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka added 4 commits

May 6, 2022 15:05


          Merge branch 'main' into sys-isinterned

40b5006


          Merge branch 'main' into sys-isinterned

39a793f


          Merge branch 'main' into sys-isinterned

71f04ba


          Update version.

4ae8dd9

methane reviewed

May 9, 2022

View reviewed changes

Comment thread

Misc/NEWS.d/next/Core and Builtins/2018-08-13-13-25-15.bpo-34392.9kIlMF.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Update Misc/NEWS.d/next/Core and Builtins/2018-08-13-13-25-15.bpo-343…

5f86a68

…92.9kIlMF.rst

Co-authored-by: Inada Naoki <[email protected]>

ezio-melotti removed the CLA signed label

Jul 13, 2022

iritkatriel previously requested changes

Nov 25, 2022

View reviewed changes

iritkatriel left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has merge conflicts now.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-bot removed the awaiting merge label

Nov 25, 2022

bedevere-bot commented Nov 25, 2022

Copy link

Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot added the awaiting changes label

Nov 25, 2022

serhiy-storchaka added 3 commits

December 3, 2022 19:09


          Merge branch 'main' into sys-isinterned

ff1a786


          Merge branch 'main' into sys-isinterned

0d4ca40


          Add a What's New entry.

f831920

serhiy-storchaka commented Dec 4, 2023

Copy link

Copy Markdown

Member Author

I have made the requested changes; please review again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka dismissed iritkatriel’s stale review

December 4, 2023 09:06

Merge conflicts are resolved.

serhiy-storchaka removed the awaiting changes label

Dec 4, 2023

serhiy-storchaka merged commit dee7bee into python:main

Dec 4, 2023

serhiy-storchaka deleted the sys-isinterned branch

December 4, 2023 09:09

serhiy-storchaka mentioned this pull request

Apr 10, 2022

Add sys.isinterned() #78573

Closed

aisk pushed a commit to aisk/cpython that referenced this pull request

Feb 11, 2024


          bpo-34392: Add sys. _is_interned() (pythonGH-8755)

281b771

Glyphack pushed a commit to Glyphack/cpython that referenced this pull request

Sep 2, 2024


          bpo-34392: Add sys. _is_interned() (pythonGH-8755)

e3ec71e

Reviewers

methane

methane approved these changes

pablogsal

pablogsal left review comments

iritkatriel

iritkatriel left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-feature

A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

serhiy-storchaka commented Aug 13, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pablogsal Aug 13, 2018

Choose a reason for hiding this comment

Uh oh!

serhiy-storchaka Aug 19, 2018

Choose a reason for hiding this comment

Uh oh!

csabella commented May 25, 2020

Uh oh!

methane commented May 26, 2020

Uh oh!

Uh oh!

iritkatriel left a comment

Choose a reason for hiding this comment

Uh oh!

bedevere-bot commented Nov 25, 2022

Uh oh!

serhiy-storchaka commented Dec 4, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

serhiy-storchaka commented Aug 13, 2018 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.