GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-34400: Fix more undefined behavior in parsetok.c by ZackerySpytz · Pull Request #8833 · python/cpython

Conversation

@ZackerySpytz

@ZackerySpytz ZackerySpytz commented Aug 20, 2018 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue34400

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ZackerySpytz
bpo-34400: Fix more undefined behavior in parsetok.c
ed6c9a6
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Aug 20, 2018
@bedevere-bot bedevere-bot added the awaiting review label Aug 20, 2018
@benjaminp benjaminp added needs backport to 3.6 skip news labels Aug 21, 2018
@benjaminp
benjaminp merged commit 3e26e42 into python:master Aug 21, 2018
@miss-islington

miss-islington commented Aug 21, 2018

Copy link
Copy Markdown
Contributor

Thanks @ZackerySpytz for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting review label Aug 21, 2018
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 21, 2018
@ZackerySpytz @miss-islington
bpo-34400: Fix more undefined behavior in parsetok.c (pythonGH-8833)
ab1278a 
(cherry picked from commit 3e26e42)

Co-authored-by: Zackery Spytz <[email protected]>
@bedevere-bot

bedevere-bot commented Aug 21, 2018

Copy link
Copy Markdown

GH-8842 is a backport of this pull request to the 3.7 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed needs backport to 3.7 labels Aug 21, 2018
@bedevere-bot

bedevere-bot commented Aug 21, 2018

Copy link
Copy Markdown

GH-8843 is a backport of this pull request to the 3.6 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Aug 21, 2018

Copy link
Copy Markdown
Contributor

Sorry, @ZackerySpytz and @benjaminp, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 3e26e42c905852394fa136f1cc564dac98b56166 2.7
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned benjaminp Aug 21, 2018
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 21, 2018
@ZackerySpytz @miss-islington
bpo-34400: Fix more undefined behavior in parsetok.c (pythonGH-8833)
509daaf 
(cherry picked from commit 3e26e42)

Co-authored-by: Zackery Spytz <[email protected]>
@benjaminp benjaminp removed the needs backport to 2.7 label Aug 21, 2018
miss-islington added a commit that referenced this pull request Aug 21, 2018
@miss-islington @ZackerySpytz
bpo-34400: Fix more undefined behavior in parsetok.c (GH-8833)
985dcd4 
(cherry picked from commit 3e26e42)

Co-authored-by: Zackery Spytz <[email protected]>
miss-islington added a commit that referenced this pull request Aug 21, 2018
@miss-islington @ZackerySpytz
bpo-34400: Fix more undefined behavior in parsetok.c (GH-8833)
e496b2b 
(cherry picked from commit 3e26e42)

Co-authored-by: Zackery Spytz <[email protected]>
ZackerySpytz added a commit to ZackerySpytz/cpython that referenced this pull request Aug 21, 2018
@ZackerySpytz
[2.7] bpo-34400: Fix more undefined behavior in parsetok.c (pythonGH-…
21b271d 
…8833).

(cherry picked from commit 3e26e42)

Co-authored-by: Zackery Spytz <[email protected]>
@ZackerySpytz

ZackerySpytz commented Aug 21, 2018

Copy link
Copy Markdown
Contributor Author

@benjaminp Thanks for the merge. I've created a backport PR for 2.7: GH-8849.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka pushed a commit that referenced this pull request Aug 22, 2018
@ZackerySpytz @serhiy-storchaka
[2.7] bpo-34400: Fix more undefined behavior in parsetok.c (GH-8833). (…
eb9a1c0 
…GH-8849)

(cherry picked from commit 3e26e42)

Co-authored-by: Zackery Spytz <[email protected]>
@ZackerySpytz
ZackerySpytz deleted the bpo-34400-more-ub-tokenizer branch August 29, 2018 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@benjaminp benjaminp

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@ZackerySpytz @miss-islington @bedevere-bot @benjaminp @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.