GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-34449: HP aCC complains about invalid -fPIC on HP-UX by michael-o · Pull Request #8847 · python/cpython

Conversation

@michael-o

@michael-o michael-o commented Aug 21, 2018 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

-fPIC is code generation option and not a link option. At compile time '+z' is
already properly used with HP aCC and shared libraries are correctly linked
with '+b'. This switch can safely be dropped.

Patch by Michael Osipov.

https://bugs.python.org/issue34449

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Aug 21, 2018
@bedevere-bot bedevere-bot added the awaiting review label Aug 21, 2018
@michael-o
michael-o force-pushed the bpo-34449 branch from 39a9f44 to df8dac9 Compare October 4, 2018 14:30
@michael-o
michael-o force-pushed the bpo-34449 branch 2 times, most recently from bc780bd to e605974 Compare April 26, 2019 09:28
@michael-o
bpo-34449: HP aCC complains about invalid -fPIC on HP-UX
426ea7e 
-fPIC is code generation option and not a link option. At compile time '+z' is
already properly used with HP aCC and shared libraries are correctly linked
with '+b'. This switch can safely be dropped.

Patch by Michael Osipov.
@michael-o
michael-o force-pushed the bpo-34449 branch from e605974 to 426ea7e Compare May 27, 2019 13:13
@michael-o michael-o mentioned this pull request Oct 28, 2021
Get rid of -fPIC chevah/python-package#114
Closed
@erlend-aasland
Merge branch 'main' into bpo-34449
921c211
@ghost

ghost commented May 19, 2022 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented May 19, 2022

Copy link
Copy Markdown
Contributor

@michael-o, can you please sign the CLA?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@michael-o

michael-o commented May 19, 2022

Copy link
Copy Markdown
Contributor Author

@erlend-aasland I am certain that I already did because other PRs from me have been absorbed into Python already. See here: https://github.com/python/cpython/commits?author=michael-o
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@michael-o

michael-o commented May 19, 2022

Copy link
Copy Markdown
Contributor Author

Ah, it was a different email address. This I can change.
erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
Merge branch 'main' into bpo-34449
6d87736
@erlend-aasland

erlend-aasland commented May 19, 2022

Copy link
Copy Markdown
Contributor

FYI, CLA is still failing. We cannot merge without it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@michael-o

michael-o commented May 19, 2022

Copy link
Copy Markdown
Contributor Author

@erlend-aasland Just signed. Please check.
erlend-aasland reacted with thumbs up emoji erlend-aasland reacted with hooray emoji
All reactions
  • 👍 1 reaction
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented May 19, 2022

Copy link
Copy Markdown
Contributor

@tiran, what do you think of this? IMO, it is nice to slim down setup.py, even though its just a couple of lines. OTOH, most of this code will probably go soon anyway (gh-90005). But, having less stuff to think about for gh-90005 is also a good thing. So I'm +1 :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tiran tiran added the needs backport to 3.11 only security fixes label May 19, 2022
tiran
tiran approved these changes May 19, 2022
View reviewed changes

@tiran tiran left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels May 19, 2022
@michael-o

michael-o commented May 19, 2022

Copy link
Copy Markdown
Contributor Author

SGTM

Awesome, 4 years of patience payed out. GCC has been dead for a very long time on HP-UX.
erlend-aasland reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland self-assigned this May 19, 2022
erlend-aasland
erlend-aasland reviewed May 19, 2022
View reviewed changes
Comment thread Misc/NEWS.d/next/Build/2018-08-21-11-10-18.bpo-34449.Z3qm3c.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
Update Misc/NEWS.d/next/Build/2018-08-21-11-10-18.bpo-34449.Z3qm3c.rst
8d3cdd5
erlend-aasland
erlend-aasland approved these changes May 19, 2022
View reviewed changes
@erlend-aasland
erlend-aasland merged commit 09be18a into python:main May 19, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label May 19, 2022
@miss-islington

miss-islington commented May 19, 2022

Copy link
Copy Markdown
Contributor

Thanks @michael-o for the PR, and @erlend-aasland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 19, 2022
@michael-o @miss-islington
pythongh-78630: Drop invalid HP aCC compiler switch -fPIC on HP-UX (p…
28b6e50 
…ythonGH-8847)

At compile time, '+z' is already properly used with HP aCC, and shared
libraries are correctly linked with '+b'. The '-fPIC' switch can safely be
dropped.
(cherry picked from commit 09be18a)

Co-authored-by: Michael Osipov <[email protected]>
@bedevere-bot

bedevere-bot commented May 19, 2022

Copy link
Copy Markdown

GH-92977 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label May 19, 2022
@erlend-aasland erlend-aasland mentioned this pull request May 19, 2022
HP aCC complains about invalid -fPIC on HP-UX #78630
Closed
miss-islington added a commit that referenced this pull request May 19, 2022
@miss-islington @michael-o
gh-78630: Drop invalid HP aCC compiler switch -fPIC on HP-UX (GH-8847)
0f1748d 
At compile time, '+z' is already properly used with HP aCC, and shared
libraries are correctly linked with '+b'. The '-fPIC' switch can safely be
dropped.
(cherry picked from commit 09be18a)

Co-authored-by: Michael Osipov <[email protected]>
@ashm-dev ashm-dev mentioned this pull request Apr 21, 2026
Build: BOLT -icf=1 breaks type-slot function-pointer identity, causes SIGSEGV #148832
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes
+1 more reviewer
@tiran tiran tiran approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@erlend-aasland erlend-aasland

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@michael-o @erlend-aasland @miss-islington @bedevere-bot @tiran @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.