GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.7] bpo-34456: pickle: Add missing NULL check to save_global(). (GH-8851) by miss-islington · Pull Request #8853 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Aug 22, 2018 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Reported by Svace static analyzer.
(cherry picked from commit f8c06b0)

Co-authored-by: Alexey Izbyshev [email protected]

https://bugs.python.org/issue34456

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Alexey Izbyshev @miss-islington
bpo-34456: pickle: Add missing NULL check to save_global(). (pythonGH…
1150397 
…-8851)

Reported by Svace static analyzer.
(cherry picked from commit f8c06b0)

Co-authored-by: Alexey Izbyshev <[email protected]>
@bedevere-bot bedevere-bot mentioned this pull request Aug 22, 2018
bpo-34456: pickle: Add missing NULL check to save_global() #8851
Merged
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Aug 22, 2018
@bedevere-bot bedevere-bot added skip news type-bug An unexpected behavior, bug, or error awaiting review labels Aug 22, 2018
@miss-islington

miss-islington commented Aug 22, 2018

Copy link
Copy Markdown
Contributor Author

@izbyshev and @serhiy-storchaka: Backport status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
1 similar comment
@miss-islington

miss-islington commented Aug 22, 2018

Copy link
Copy Markdown
Contributor Author

@izbyshev and @serhiy-storchaka: Backport status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka
serhiy-storchaka approved these changes Aug 22, 2018
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Aug 22, 2018
@miss-islington
miss-islington merged commit 3152bc3 into python:3.7 Aug 22, 2018
@bedevere-bot bedevere-bot removed the awaiting merge label Aug 22, 2018
@miss-islington
miss-islington deleted the backport-f8c06b0-3.7 branch August 22, 2018 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.