GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-34456: pickle: Add missing NULL check to save_global() by izbyshev · Pull Request #8851 · python/cpython

Conversation

@izbyshev

@izbyshev izbyshev commented Aug 21, 2018 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Reported by Svace static analyzer.

https://bugs.python.org/issue34456

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Alexey Izbyshev
bpo-34456: pickle: Add missing NULL check to save_global()
5e25791 
Reported by Svace static analyzer.
@bedevere-bot bedevere-bot added the awaiting review label Aug 21, 2018
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Aug 21, 2018
serhiy-storchaka
serhiy-storchaka approved these changes Aug 22, 2018
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Aug 22, 2018
@serhiy-storchaka serhiy-storchaka added skip news type-bug An unexpected behavior, bug, or error needs backport to 3.6 labels Aug 22, 2018
@serhiy-storchaka
serhiy-storchaka merged commit f8c06b0 into python:master Aug 22, 2018
@miss-islington

miss-islington commented Aug 22, 2018

Copy link
Copy Markdown
Contributor

Thanks @izbyshev for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Aug 22, 2018
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 22, 2018
Alexey Izbyshev @miss-islington
bpo-34456: pickle: Add missing NULL check to save_global(). (pythonGH…
1150397 
…-8851)

Reported by Svace static analyzer.
(cherry picked from commit f8c06b0)

Co-authored-by: Alexey Izbyshev <[email protected]>
@bedevere-bot

bedevere-bot commented Aug 22, 2018

Copy link
Copy Markdown

GH-8853 is a backport of this pull request to the 3.7 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.7 label Aug 22, 2018
@bedevere-bot

bedevere-bot commented Aug 22, 2018

Copy link
Copy Markdown

GH-8854 is a backport of this pull request to the 3.6 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.6 label Aug 22, 2018
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 22, 2018
Alexey Izbyshev @miss-islington
bpo-34456: pickle: Add missing NULL check to save_global(). (pythonGH…
d79151d 
…-8851)

Reported by Svace static analyzer.
(cherry picked from commit f8c06b0)

Co-authored-by: Alexey Izbyshev <[email protected]>
miss-islington added a commit that referenced this pull request Aug 22, 2018
@miss-islington Alexey Izbyshev
bpo-34456: pickle: Add missing NULL check to save_global(). (GH-8851)
3152bc3 
Reported by Svace static analyzer.
(cherry picked from commit f8c06b0)

Co-authored-by: Alexey Izbyshev <[email protected]>
miss-islington added a commit that referenced this pull request Aug 22, 2018
@miss-islington Alexey Izbyshev
bpo-34456: pickle: Add missing NULL check to save_global(). (GH-8851)
b14a68f 
Reported by Svace static analyzer.
(cherry picked from commit f8c06b0)

Co-authored-by: Alexey Izbyshev <[email protected]>
@izbyshev
izbyshev deleted the bpo-34456 branch August 22, 2018 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@izbyshev @miss-islington @bedevere-bot @serhiy-storchaka @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.