Copy link

Copy Markdown

Contributor

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
- Coverage   82.37%   82.37%   -0.01%     
==========================================
  Files        1427     1427              
  Lines      350948   350948              
==========================================
- Hits       289090   289079      -11     
- Misses      61858    61869      +11

methane approved these changes Feb 11, 2017

View reviewed changes

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

* Fix some deprecation warnings in Doc/conf.py
* Fix an rst error in Misc/NEWS

Contributed by Ryan Gonzalez @kirbyfan64

(cherry picked from commit e7ffb99)

* Fix some deprecation warnings in Doc/conf.py
* Fix an rst error in Misc/NEWS

Contributed by Ryan Gonzalez @kirbyfan64

(cherry picked from commit e7ffb99)

* Fix some deprecation warnings in Doc/conf.py
* Fix an rst error in Misc/NEWS

Contributed by Ryan Gonzalez @kirbyfan64

(cherry picked from commit e7ffb99)

* Fix some deprecation warnings in Doc/conf.py
* Fix an rst error in Misc/NEWS

Contributed by Ryan Gonzalez @kirbyfan64

(cherry picked from commit e7ffb99)

python#7287 (comment)

9: Warn for using built-in open r=ltratt a=nanjekyejoannah

Warn for file open. I was struggling to support the generic case assuming io.open doesnt exist.
A warning is simpler to do assuming support for >=2.6. I added notes in the Google doc for this.

Co-authored-by: Joannah Nanjekye <[email protected]>

More PEP-810 compatibility, fix memory leaks and LOAD_ATTR specialization

Convert HIRBuilder::emitLoadMethodOrAttrSuper from C++ multi-block
deopt+dispatch to a thin delegation stub. New C function
hir_builder_emit_load_method_or_attr_super_c builds the deopt path
(snapshot+deopt) and fast path (CondBranchCheckType + RefineType +
LoadAttrSuper or LoadMethodSuper+GetSecondOutput).

C++ stub computes nothing — passes oparg + bc_offset.value() through
to C. The C body computes name_idx/load_method/no_args from oparg
(3.11+ packing per theologian audit python#3 — load_method param overwrite),
following the project's 3.12-only convention dropping the pre-3.11
oparg-tuple branch.

Theologian invariant audit (2026-04-22 11:58:52Z) drives the
implementation:

  python#1 phx_frame_state_copy runs BEFORE the 3 pops so deopt-path frame
     preserves PRE-POP stack for interpreter resumption
  python#4 pop order: receiver (TOS), type, global_super
  python#5 push order varies by load_method (1 value vs 2)
  python#8 deopt-path emits go into deopt_tc.block
  python#9 CondBranchCheckType branches; tc.block <- fast_path; emit
     RefineType in-place

Both exit paths phx_frame_state_destroy the deopt_tc to avoid leaking
the heap-allocated stack/locals arrays.

testkeeper pre-commit verify (2026-04-22 12:15:46Z): JIT_BUILD_EXIT=0,
full BUILD_EXIT=0, 7/7 phoenix-jit tests PASS at HEAD+uncommitted.
W26 gate-hardening not triggered (no recent fail).

Port HIRBuilder::findExceptionHandler to a pure-C body that scans the
exception_table_ via two new C++-side read bridges (size + entry
field-by-value access). C++ shim preserves caller-contract by
returning &exception_table_[idx] from the matching index.

Per spec §5 Class B-kept disposition for exception_table_ now CLOSED
(read+write both via bridge):
- Batch 1: hir_builder_state_exception_table_push_cpp (write)
- Batch 2: hir_builder_state_exception_table_size_cpp (read meta)
- Batch 2: hir_builder_state_exception_table_entry_cpp (read field)
- Batch 2: hir_builder_state_find_exception_handler_c (C body)

Pattern propagatable to similar Class B-kept members (pending_b2_blocks_,
etc.) in subsequent batches.

Bridges added (3, within W25b ≤5/batch):
  hir_builder_state_exception_table_size_cpp(builder) -> int
  hir_builder_state_exception_table_entry_cpp(builder, idx, *out_5fields)
  hir_builder_state_find_exception_handler_c(state, builder, off, *out_idx) -> int

Cumulative exception_table_ bridge surface = 4 (push + size + entry + find);
all under cumulative budget for the member.

Numstat (vs HEAD c905827):
  Python/jit/hir/builder.cpp           +29 -4  (size + entry impls; shim)
  Python/jit/hir/builder.h             +5  -0  (2 friend decls + comment)
  Python/jit/hir/builder_state_c.h     +27 -0  (3 new bridge decls)
  Python/jit/hir/builder_state_c.c     +19 -0  (find_exception_handler_c)
  scripts/w45_bridge_drift_falsifier.sh +8  -4 (3 new fixtures + non-void
                                                 return-type regex update)
TOTAL: NET +80L (forecast +74L; +6L variance ~8%, within theologian
15% threshold for forecast accuracy).

W45 fixtures: 3 new (state_exception_table_size_cpp,
state_exception_table_entry_cpp, state_find_exception_handler_c) added
per shepard 22:46:33Z same-commit discipline. W45 perl regex updated
to match any return type (was void-only) since size_cpp returns int.
Dry-run: 12/12 fixtures stage cleanly.

Pre-commit compile-check: testkeeper 23:27:11Z BUILD_EXIT=0,
3-test sanity green (partial_conversions + W22 + W44).

W44 gate: PASS.

Authorization: theologian 23:22:59Z + supervisor 23:23:10Z. Per spec
§6 python#9 + amendment 23:09:50Z, per-commit benchmark gate runs post-
commit (geo-mean must stay >=1.0x parity floor).