GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-34595: Add %T format to PyUnicode_FromFormatV() by vstinner · Pull Request #9080 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Sep 6, 2018 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Add %T format to PyUnicode_FromFormatV(), and so to
    PyUnicode_FromFormat() and PyErr_Format(), to format an object type
    name: equivalent to "%s" with Py_TYPE(obj)->tp_name.
  • Replace Py_TYPE(obj)->tp_name with %T format in unicodeobject.c.
  • Add unit test on %T format.
  • Rename unicode_fromformat_write_cstr() to
    unicode_fromformat_write_utf8(), to make the intent more explicit.

https://bugs.python.org/issue34595

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
bpo-34595: Add %T format to PyUnicode_FromFormatV()
9a422f3 
* Add %T format to PyUnicode_FromFormatV(), and so to
  PyUnicode_FromFormat() and PyErr_Format(), to format an object type
  name: equivalent to "%s" with Py_TYPE(obj)->tp_name.
* Replace Py_TYPE(obj)->tp_name with %T format in unicodeobject.c.
* Add unit test on %T format.
* Rename unicode_fromformat_write_cstr() to
  unicode_fromformat_write_utf8(), to make the intent more explicit.
@vstinner
vstinner requested review from pablogsal and serhiy-storchaka September 6, 2018 09:19
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Sep 6, 2018
@bedevere-bot bedevere-bot added the awaiting merge label Sep 6, 2018
JulienPalard
JulienPalard approved these changes Sep 7, 2018
View reviewed changes
pablogsal
pablogsal approved these changes Sep 7, 2018
View reviewed changes
@vstinner
vstinner merged commit 886483e into python:master Sep 7, 2018
@bedevere-bot bedevere-bot removed the awaiting merge label Sep 7, 2018
@vstinner
vstinner deleted the unicode_fromformat_t branch September 7, 2018 16:01
@vstinner

vstinner commented Sep 7, 2018

Copy link
Copy Markdown
Member Author

Thanks for the review @JulienPalard and @pablogsal!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner added a commit that referenced this pull request Sep 11, 2018
@vstinner
Revert "bpo-34595: Add %T format to PyUnicode_FromFormatV() (GH-9080)" (
998b806 
GH-9187)

This reverts commit 886483e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JulienPalard JulienPalard JulienPalard approved these changes
@pablogsal pablogsal pablogsal approved these changes
@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@vstinner @JulienPalard @pablogsal @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.