GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-69093: sqlite3 blob doc amendments by erlend-aasland · Pull Request #91561 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Apr 15, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • document that you cannot open a blob handle in a WITHOUT ROWID table
  • document the blobopen() positional arguments in the same order as they
    appear
  • relocate sqlite3.Blob class section

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Erlend E. Aasland
pythongh-69093: sqlite3 blob doc amendments
dbdf25f 
- document that you cannot open a blob handle in a WITHOUT ROWID table
- document the blobopen() positional arguments in the same order as they
  appear
@erlend-aasland
erlend-aasland requested a review from berkerpeksag as a code owner April 15, 2022 06:54
@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir labels Apr 15, 2022
@erlend-aasland
erlend-aasland requested a review from JelleZijlstra April 15, 2022 06:54
@erlend-aasland erlend-aasland added the skip news label Apr 15, 2022
@erlend-aasland erlend-aasland mentioned this pull request Apr 15, 2022
gh-69093: Support basic incremental I/O to blobs in sqlite3 #30680
Merged
dholth
dholth approved these changes Apr 15, 2022
View reviewed changes

@dholth dholth left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pr is more clear, thanks

Also integer primary key: https://www.sqlite.org/rowidtable.html

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Apr 15, 2022
JelleZijlstra
JelleZijlstra reviewed Apr 15, 2022
View reviewed changes
Comment thread Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Erlend Egeberg Aasland and others added 4 commits April 15, 2022 16:01
Erlend Egeberg Aasland @JelleZijlstra
Update Doc/library/sqlite3.rst
0cd1fdf 
Co-authored-by: Jelle Zijlstra <[email protected]>
Erlend E. Aasland
Merge branch 'main' into sqlite-blob-improve-docs
24ac410
Erlend E. Aasland
Relocate sqlite3.Blob section
13c4f2f
Erlend E. Aasland
Merge remote-tracking branch 'origin/sqlite-blob-improve-docs' into s…
5b85974 
…qlite-blob-improve-docs
@erlend-aasland erlend-aasland mentioned this pull request Apr 16, 2022
gh-69093: Add mapping protocol support to sqlite3.Blob #91599
Merged
JelleZijlstra
JelleZijlstra approved these changes Apr 16, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Apr 16, 2022
@JelleZijlstra
JelleZijlstra merged commit 95573ad into python:main Apr 16, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Apr 16, 2022
@erlend-aasland
erlend-aasland deleted the sqlite-blob-improve-docs branch April 16, 2022 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag
+1 more reviewer
@dholth dholth dholth approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@erlend-aasland @dholth @JelleZijlstra @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.